1676441 - Tweaks, test infrastructure and test cases for wasm memories > INT32_MAX

Status: ASSIGNED

(Core :: Javascript: WebAssembly, enhancement, P2)

Description

[Lars T Hansen [:lth]]

Various test cases for wasm memories > 2GB, and tweaks and infrastructure to make them pass.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Allow up to 65534 pages + test cases

Comment 2

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Going from 65534 to 65536 is hard, WIP

Depends on D96602

Comment 3

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - CreateWasmSpecificBuffer can accept more than UINT32_MAX initial size

Depends on D96602

Comment 4

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Upgrade to size_t in the easy cases

Depends on D98969

Comment 5

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - boundsCheck32 fixes (WIP)

Depends on D98970

Comment 6

[Lars T Hansen [:lth]]

The plan for asm.js is to restrict it to 2GB, so that we do not have to vet the semantics + the implementation to handle more. This has been implemented as a check during linking, and iiuc a link failure means we'll just fall back to JS, so asm.js programs will be able to use the larger heaps, but they will be run as JS, not translated to wasm.

Comment 7

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Bounds checking part 1: Setup

Make the bounds check limit field platform-dependent and tidy up some
naming.

Make sure asm.js tests are run with explicit bounds checking also on
64-bit platforms.

Depends on D98970

Comment 8

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Bounds checking part 2: Add 64-bit masm api

Add wasmBoundsCheck64() APIs that will take a 64-bit index and 64-bit
limit, to be used on all 64-bit platforms.

Document how the bounds checking primitives are supposed to be used.

Depends on D99097

Comment 9

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Bounds checking part 3: Baseline support

Use the new 64-bit API on 64-bit systems (after widening the index
appropriately) and the 32-bit API on 32-bit systems.

Depends on D99098

Comment 10

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Bounds checking part 4: Ion support

Update the Ion pipeline to support 64-bit bounds for wasm on 64-bit
platforms, and 32-bit bounds for asm.js everywhere and wasm on 32-bit
platforms.

Depends on D99102

Comment 11

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Bounds checking part 5: Cranelift support, WIP

Depends on D99103

Comment 12

[Lars T Hansen [:lth]]

Attachment: Bug 1676441 - Initial notes about 65536 pages

Depends on D99104