1676442 - ADD - ONS google translate not working

Status: RESOLVED WONTFIX

(WebExtensions :: Developer Outreach, defect)

Description

[Kumar Ritu Raj]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Add Google Translate form Mozilla ADD - ONS. Then open it to translate.

Actual results:

It can't work, just searching.

Expected results:

It should be open to translate page. Even Google Translate normally work on new tab.

Comment 1

[Kumar Ritu Raj]

Attachment: WhatsApp Image 2020-11-10 at 10.15.03 PM.jpeg

It is not working, just searching.

Comment 2

[Alex Cornestean]

Hello,

I’ve managed to reproduce the issue with version 4.0.6 of the add-on, however, the behavior was not consistent at all. Please see my observations below:

Release:

• with several new profiles, the reported issue occurred every time I clicked the add-on icon.
• with several other new profiles, I can no longer reproduce the issue when clicking the add-on icon. The pop-up opens and the correct UI is displayed each time.

Beta:

• with several new profiles, the issue occurred every time I clicked the add-on icon.
• with another new profile, the first click on the add-on icon properly displayed the pop-up UI. Subsequent clicks on the add-on icon displayed the loading animation i.e. the issue occurred.

Nightly:

• with several new profiles, the issue occurred each time.
• with another new profile, the issue occurred on the first click on the add-on icon, however on subsequent clicks the issue no longer occurred.

Context menu options still work correctly.

With the latest version of the add-on (4.1.0), the browser action has been removed and the only way to use the add-on is via the context menu options or keyboard shortcuts, which work as intended.

This was tested on the latest Nightly (84.0a1/20201111163850), Beta (83.0/20201110140026) and Release (82.0.3/20201108180448) under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS.

I’m not going to set the affected versions flags as of yet, due to the inconsistent behavior.

Comment 3

[Rob Wu [:robwu]]

Reported at https://github.com/itsecurityco/to-google-translate/issues/122

Not clear if this is a bug in the add-on or in Firefox.

Alex, could you run mozregression to find a regression range?

Comment 4

[Alex Cornestean]

Hi Rob,

Performed the bisection as requested. Due to the inconsistent behavior observed earlier, please note that:

1. If the pop-up UI failed to be displayed once or twice (usually at the start of me clicking the add-on icon) but the remaining tries out of ~20-25 were successful in displaying the UI, I considered the build Good.
2. If the pop-up UI was displayed once or twice in the beginning but subsequent tries failed, I considered the build Bad.

As such, I’ve narrowed it down to https://bugzilla.mozilla.org/show_bug.cgi?id=1640906 (2020-11-17T14:11:56.702000: DEBUG : Found commit message: Bug 1640906 - Fixed intermittent timeout of toolkit/components/httpsonlyerror/tests/browser/browser_exception.js. r=ckerschb) with this differential revision: https://phabricator.services.mozilla.com/D77041.

The corresponding pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5b97f74fb6fd047fcd7fb75a4a71bb9a0ffa9e3a&tochange=bce254694878b2209375fe1dc281cedeec34cdba

In case of error, let me know and I’ll repeat the bisection. Thanks !

Comment 5

[Rob Wu [:robwu]]

That bisection result is incorrect. The referenced patch is a test-only change of an unrelated test. Could you try again? Thanks!

Comment 6

[Alex Cornestean]

My apologies for the delay Rob, I was on PTO.

Re-did the bisection and narrowed it down to: https://bugzilla.mozilla.org/show_bug.cgi?id=1502355 (2020-11-24T13:14:59.585000: DEBUG : Found commit message: Bug 1502355 - Allocate |PipeToState| as tenured, for perhaps marginally greater efficiency. r=arai) with this differential revision: https://phabricator.services.mozilla.com/D92350 .

This is the pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88834ed9b3fc6e6879b1a7f1d4b987ff11ea4b99&tochange=195dfba58e2215d8f57f414d1b306e5240cb1b75 .

Comment 7

[juraj.masiar]

This is not related to Firefox / addon. It's some new Google Translate security measure applied to some requests (that's why the inconsistent behavior).
I'm author of similar addon and I face the same problem in Firefox / Thunderbird and even Chrome:
https://addons.mozilla.org/addon/web_translate/

There is (probably) some script that detects that page was loaded into iframe and it then redirects user to "about:blank" thus breaking the whole translator.

Comment 8

[Rob Wu [:robwu]]

Thanks for the info Juraj. Given your comment and the inconsitent bisection result, I'll close this bug. There is nothing that we can do from Firefox's side; it's the add-on author's responsibility to adopt to changes in Google Translate.