1676523 - Consider unifying Toolkit and GeckoView's about:config

Status: NEW

(Toolkit :: Preferences, task, P5)

Description

[Tim Nguyen :ntim]

This is pretty annoying for moving the HTML browser/ implementation of aboutconfig to toolkit/, since the browser/ one has a HTML file extension, while the geckoview uses XHTML (because it still uses XUL menus).

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1676523 - about:config: Don't override toolkit files on GeckoView and simplify AboutRedirector logic.

Comment 2

[Tim Nguyen :ntim]

After discussing with Agi, Agi suggested (for better toolkit/app separation) that we instead make the desktop version responsive, move it to toolkit and remove the mobile version+override machinery.

A working prototype was (thanks Agi!):

• Removing min-width: 644px from the CSS file
• Use toolkit assets instead of browser ones (bug 1524836 needs to do this anyway)
• Adding a meta viewport tag
• Adding this CSS:

@media (max-width: 644px) {
  #prefs > tr > th,
  #prefs > tr > td.cell-value {
     display: block;
     padding-left: 30px;
  }
  #prefs > tr > th {
     padding-top: 10px;
  }
  #prefs > tr > td {
     padding-bottom: 10px;
  }
}

I don't have more time to spend on this bug, but it would be nice to have a clear path forward for bug 1524836.

Gijs, what do you think of using the desktop version on mobile as Agi suggested or the alternatives?

Some alternative solutions are:

1. adding a Android specific AboutRedirector (though I expect this isn't trivial)
2. adding a dummy config.xhtml in toolkit at the same time as bug 1524836

Comment 3

[:Gijs (he/him)]

(In reply to Tim Nguyen :ntim from comment #2)

Gijs, what do you think of using the desktop version on mobile as Agi suggested

If the mobile folks are happy with this it works for me. If the CSS changes don't break (e.g. require touch input) on desktop, I don't think it's a problem for desktop, though it'd be useful if there were good tests so that we didn't inadvertently break the mobile version if we changed things on desktop.

or the alternatives?

Some alternative solutions are:

1. adding a Android specific AboutRedirector (though I expect this isn't trivial)
2. adding a dummy config.xhtml in toolkit at the same time as bug 1524836

I don't really understand what either of these two solve, can you elaborate?

Comment 4

[Tim Nguyen :ntim]

(In reply to :Gijs (he/him) from comment #3)

If the mobile folks are happy with this it works for me. If the CSS changes don't break (e.g. require touch input) on desktop, I don't think it's a problem for desktop, though it'd be useful if there were good tests so that we didn't inadvertently break the mobile version if we changed things on desktop.

Sounds good.

Some alternative solutions are:

1. adding a Android specific AboutRedirector (though I expect this isn't trivial)
2. adding a dummy config.xhtml in toolkit at the same time as bug 1524836

I don't really understand what either of these two solve, can you elaborate?

Both allow removing/working around the problematic override here: https://searchfox.org/mozilla-central/rev/c37038c592a352eda0f5e77dfb58c4929bf8bcd3/mobile/android/chrome/geckoview/jar.mn#10

The work has started in bug 1524836, so I suspect they'll need to go with either path.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Presuming the GeckoView folks are into it, I think this makes sense to me.