1676569 - JavaScript error: resource://gre/actors/PictureInPictureChild.jsm, line 453: TypeError: can't access property "requestIdleCallback", this.contentWindow is null

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Since the patch on bug 1669961 got landed, various Marionette jobs show the above Javascript error. So most likely a regression.

https://treeherder.mozilla.org/logviewer?job_id=321376830&repo=autoland&lineNumber=8733-8734

Here the affected source:

https://searchfox.org/mozilla-central/rev/02cb78667e87ccc42fea5edc6f3f2dd2edd6ecd5/toolkit/actors/PictureInPictureChild.jsm#452-454

Comment 1

[Kris Maglione [:kmag]]

This is a PiP bug, which bug 1669961 just made more obvious. Prior to that, it would have just silently did the wrong thing, trying to register idle callbacks and remove event listeners from the wrong inner window. Except that under Fission, it would have failed anyway whenever the BrowsingContext navigated and changed process.

Comment 2

[Pascal Chevrel:pascalc]

Mike, could you weigh in on this bug wrt to the priority/Severity? Thanks

Comment 3

[Oliver Pope]

Attachment: Bug 1676569 - Avoid calling requestIdleCallback when contentWindow is not available

Comment 4

[Micah [:mtigley] (she/her)]

Henrik, I can't seem to reproduce this locally or using a push to "try" for Marionette jobs. Is this issue still happening?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can see this in each and every Mn job on mozilla-central:
https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=mn

Just get the full log and search for the URI.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This moved to line 453 now:

https://treeherder.mozilla.org/logviewer?job_id=329703044&repo=mozilla-central&lineNumber=9155-9156

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Here some steps to easily reproduce the failure, and that shows that it has nothing to do with Marionette or other test harnesses:

1. Load data:text/html;charset=utf-8,%3Cvideo%20loop%3E
2. Reload the page

After step 2 the failure will be visible in the console of the multi-process browser toolbox.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There are also other errors visible for me:

can't access property "removeAttribute", shadowRoot.firstChild is null PictureInPictureChild.jsm:830
TypeError: can't access property "removeEventListener", this.contentWindow is null PictureInPictureChild.jsm:571:5
InvalidStateError: JSWindowActorChild.document getter: Cannot access property 'document' after actor 'PictureInPictureToggle' has been destroyed

Will those be fixed at the same time or shall I file new bugs?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfbef0e4eac2
Avoid calling requestIdleCallback when contentWindow is not available r=mtigley,mhowell

Comment 10

[Oliver Pope]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #8)

There are also other errors visible for me:

can't access property "removeAttribute", shadowRoot.firstChild is null PictureInPictureChild.jsm:830
TypeError: can't access property "removeEventListener", this.contentWindow is null PictureInPictureChild.jsm:571:5
InvalidStateError: JSWindowActorChild.document getter: Cannot access property 'document' after actor 'PictureInPictureToggle' has been destroyed

Will those be fixed at the same time or shall I file new bugs?

follow up bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1695020

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bfbef0e4eac2