1676585 - The block-start and block-end border are not painted on the correct side if the block is fragmented in vertical-rl writing mode

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: border-vertical-rl.html

Steps to reproduce:
Open the attached html, and see Testcase 3.

Actual result:
In the writing-mode: vertical-rl multicol, the block-start border (red) of the fragmented block the in first column is not painted. Instead, the red border is painted on the block-end side.

Similarly, the block-end border (green) of the fragmented block in the second column is not painted. Instead, the green border is painted on the block-start side.

Expected result:
The border is painted on the correct side on a fragmented block.

Note: The border is correctly painted if the block isn't fragmented (Testcase 2). The border is also correct if the block is fragmented in writing-mode: vertical-rl multicol (Testcase 1).

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1676585 Part 1 - Simplify vertical-wm-001.html by using logical properties.

This patch shouldn't change the rendering of the test at all.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1676585 Part 2 - Use LogicalRect to compute joining boxes' border area.

The original code doesn't work for "writing-mode:vertical-rl" because
its block flow direction is the opposite of "writing-mode:vertical-lr."

Depends on D96785

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3d67ca563cf
Part 1 - Simplify vertical-wm-001.html by using logical properties. r=mats
https://hg.mozilla.org/integration/autoland/rev/4c7e56ad44b2
Part 2 - Use LogicalRect to compute joining boxes' border area. r=mats

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f3d67ca563cf
https://hg.mozilla.org/mozilla-central/rev/4c7e56ad44b2