1676708 - Invalid date parsing with GMT starting with 00

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Calixte Denizet (:calixte)]

For example in Firefox nightly 84:

>> new Date("Wed Nov 11 2020 19:18:50 GMT+0010 (Central European Standard Time)").toUTCString()
-> "Wed, 11 Nov 2020 09:18:50 GMT"

when it should be "Wed, 11 Nov 2020 19:08:50 GMT"

Comment 1

[Calixte Denizet (:calixte)]

We probably need to check partLength too here:
https://searchfox.org/mozilla-central/source/js/src/jsdate.cpp#1187

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1676708 -- Parse a date with GMT+00xx leads to an incorrect timezone offset

The MDN documentation specifies that 00xx stands for 0 hours and xx minutes.
So that patch adds a check with the length of the offset to be sure that minutes won't become hours.

Comment 3

[Nicolas B. Pierron [:nbp]]

Calixte, would you have time to move the test case to a different file, as suggested in https://phabricator.services.mozilla.com/D96755#3166362 ?

Comment 4

[Calixte Denizet (:calixte)]

I just moved the test in parse-time-zone.js file.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29161b592e83
Parse a date with GMT+00xx leads to an incorrect timezone offset r=jorendorff

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/29161b592e83