1676721 - Assertion failure: !mPuppetWidget->HasLayerManager(), at dom/ipc/BrowserChild.cpp:2694 when printing fission iframe via window.print()

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case

See the test-case. This is basically bug 1676188.

This assert reproduces also without the patch, but the patch makes it much more frequent locally, and I believe it's at least part of the reason that bug happens.

I think what's going on is that we re-initialize the fission iframe's rendering twice under some circumstances, and that ends up confusing the compositor...

Before writing the patch for that bug I could barely reproduce it, but afterwards I can reproduce it basically consistently, so I should be able to dig more into this, but since the patch in there fixes the user-visible issue and also is a less brittle setup I think we should take it and move that here.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Ah, I need the gfx.content.always-paint set to true for that to repro...

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1676721 - Fix an incorrect assertion. r=mattwoodrow

See the comment as for why.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/990cc484f91a
Fix an incorrect assertion. r=mattwoodrow

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/990cc484f91a