1676808 - Expose WatcherFront via TargetList (instead of ResourceWatcher)

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Currently, ResourceWatcher exposes the WatcherFront via a watcher attribute.
https://searchfox.org/mozilla-central/rev/50215d649d4854812837f1343e8f47bd998dacb5/devtools/shared/resources/resource-watcher.js#111

But it appears that TargetList also uses the watcher front:
https://searchfox.org/mozilla-central/rev/50215d649d4854812837f1343e8f47bd998dacb5/devtools/shared/resources/target-list.js#288
and we would benefit from exposing it from TargetList as this is a sub-component of ResourceWatcher.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1676808 - [devtools] Expose WatcherFront via the TargetList instead of ResourceWatcher.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1676808 - [devtools] Rename all watcher to watcherFront.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1676808 - [devtools] Rename ResourceWatcher.hasWatcherSupport to hasResourceWatcherSupport.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03abab648794
[devtools] Expose WatcherFront via the TargetList instead of ResourceWatcher. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9e26cb0f0bdf
[devtools] Rename ResourceWatcher.hasWatcherSupport to hasResourceWatcherSupport. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/bc9b1ba331c3
[devtools] Rename all watcher to watcherFront. r=jdescottes

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1676808) for causing devtools failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=PzdVTH_WSQq3de87Q3o4uw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=bc9b1ba331c38e19d066cfa642ebc60650067591

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321966250&repo=autoland&lineNumber=8515
https://treeherder.mozilla.org/logviewer?job_id=321966223&repo=autoland&lineNumber=2680

Backout: https://hg.mozilla.org/integration/autoland/rev/5af57fd285f1cfe988fafd7f217a47d0923e0531

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/575f1754a9ce
[devtools] Expose WatcherFront via the TargetList instead of ResourceWatcher. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/16d35d5bf7f2
[devtools] Rename ResourceWatcher.hasWatcherSupport to hasResourceWatcherSupport. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/6dba1920e0cc
[devtools] Rename all watcher to watcherFront. r=jdescottes

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/575f1754a9ce
https://hg.mozilla.org/mozilla-central/rev/16d35d5bf7f2
https://hg.mozilla.org/mozilla-central/rev/6dba1920e0cc