167689 - On URL drag show tab ghost on tab bar destination

Status: VERIFIED FIXED

(Camino Graveyard :: Tabbed Browsing, enhancement, P3)

Description

[Wincent Colaiuta]

Using Chimera 0.50 and dragging a proxy icon into the tab background area to
create a new tab, the new tabs always appear on the right. This works great if
you drag to the background on the right, but becomes counter-intuitive when you
drag to the background area on the left.

For example, to reproduce:
- open a window with a couple of tabs in it
- drag a tab proxy icon to the tab background area on the left (the tab
background on both sides highlights)
- release the mouse button

Expected behaviour: new tab appears to the left of all tabs.

Actual result: new tab appears to the right of all tabs.

This problem because especially evident when the window already has a large
number of tabs in it, because it means you have to drag further to the left in
order to drop the icon, yet the new tab appears even further to the right. This
makes the disparity between the drop-destination and the point where the tab
appears even more obvious to the user.

Comment 1

[Greg K.]

I'll confirm as an RFE. Reassigning to Tabbed Browser. Chimera should probably
show a ghost tab showing where it will be created when the button is released.

Probably related to bug 160720.

Comment 2

[Mike Pinkerton (not reading bugmail)]

over to simon who may want to do this.

Comment 3

[Jasper]

Geoff this is something for you to think about.

Comment 4

[Jasper]

Changing bug to On URL drag show tab ghost on tab bar destination. The new tab
view now has left aligned tabs. So we no longer have the original issue all tabs
are now created on the right side.

Geoff this one is for you aswell I think.

Comment 5

[Martin Girschick]

This feature seems to be broken party with the introduction of the new tabs. At
least sometimes Camino doesn't accept the drag and no new tab is created.

Comment 6

[Simon Fraser [no longer active]]

Related to bug 265994.

Comment 7

[Jasper]

Attachment: mockup for inspirational

A mockup for inspirational purposes. It shows how I think we should handle the
drawing of drag states in the future.

It showcases the target drag state for:
1) active tab
2) inactive tab
3) "tab ghost" for new tab

Comment 8

[Jasper]

Attachment: new one

I can imagine we would also draw the globe icon and the the url text (or title
when available) on the tab ghost for tab bar destination, slightly transparant.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Jasper, I already get a blue highlight (my system highlight color) on the tab
when I try to drag something to an existing tab (although it's rectangular to
match the tab rather than your oval-ish mockup)...it really looks like that just
needs to be replicated for the "ghost tab" drag.

Comment 10

[Samuel Sidler (old account; do not CC)]

I can see the need for this, but I'm not sure it should block 1.0. Thoughts?

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #10)
> I can see the need for this, but I'm not sure it should block 1.0. Thoughts?

Not for the new-world 1.0.  We already get a highlight when dragging to existing
tab, and we get the green plus when dragging to blank space on the tab bar or
the overflow widget.  

At this point, this is polish to make the blank space on the tab bar visually
consistent with existing tabs.  Probably 1.2 now?

Comment 12

[Jasper]

Bump for simon

Comment 13

[Simon Fraser [no longer active]]

Drawing a ghost tab is a little harder than highlighting the background of the bar, which is what I've done.

Comment 14

[Samuel Sidler (old account; do not CC)]

I'd say this bug is "fixed" with the highlighting. Do we really need to see a rounded version? Does it even look much better? I, personally, prefer the highlight to what I'm seeing in the screenshots.

Jasper, what do you think?

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think what we have now (comment 13) is good, and it sounds like it's a lot of work for very little gain to do the actual "ghost tab".  Let's call this FIXED and move on.

Comment 16

[Samuel Sidler (old account; do not CC)]

Let's call this fixed. Jasper, you can reopen if you disagree.