Closed Bug 1676897 Opened 5 years ago Closed 5 years ago

Remove obsolete resolutionchange handling from LightweightThemeConsumer.jsm

Categories

(WebExtensions :: Themes, task, P1)

Product:
WebExtensions
Component:
Themes
Type:
task
Points:
1

Tracking

(firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Iteration:
84.2 - Nov 2 - Nov 15
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Bug 1676897 - Remove obsolete resolutionchange handling from LightweightThemeConsumer.jsm. r=ntim
47 bytes, text/x-phabricator-request
Details | Review

From bug 1661295 comment 9:

I suspect the resolutionchange handling is broken: https://searchfox.org/mozilla-central/rev/c2e3ac11be4837718c2604e58085fbc8252b69dd/toolkit/modules/LightweightThemeConsumer.jsm#258
I think handling this event goes back to when we had LightweightThemeImageOptimizer.jsm which would crop the header image. That module doesn't exist anymore. It looks like we shouldn't handle this event anymore?

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1587ac7fbae8 Remove obsolete resolutionchange handling from LightweightThemeConsumer.jsm. r=ntim

https://hg.mozilla.org/mozilla-central/rev/1587ac7fbae8

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: