1676997 - Crash in [@ xpc::NativeGlobal] from PromiseJobRunnable::Suppressed()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/4720e58c-8aa9-4846-8fba-304d20201112

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0 XUL xpc::NativeGlobal js/xpconnect/wrappers/WrapperFactory.cpp:778
1 XUL mozilla::CycleCollectedJSContext::PerformMicroTaskCheckPoint xpcom/base/CycleCollectedJSContext.cpp:631
2 XUL mozilla::EventListenerManager::HandleEventInternal dom/events/EventListenerManager.cpp:1270
3 XUL mozilla::EventTargetChainItem::HandleEventTargetChain dom/events/EventDispatcher.cpp:554
4 XUL mozilla::EventDispatcher::Dispatch dom/events/EventDispatcher.cpp:1093
5 XUL mozilla::EventDispatcher::DispatchDOMEvent dom/events/EventDispatcher.cpp:1195
6 XUL mozilla::DOMEventTargetHelper::DispatchEvent dom/events/DOMEventTargetHelper.cpp:145
7 XUL mozilla::dom::EventTarget::DispatchEvent dom/events/EventTarget.cpp:183
8 XUL mozilla::dom::indexedDB:: dom/indexedDB/ActorsChild.cpp:626
9 XUL mozilla::dom::indexedDB::BackgroundRequestChild::HandleResponse dom/indexedDB/ActorsChild.cpp:2431

There are a few of these crashes. PromiseJobRunnable::Run() does a null check on the callback, but Suppressed() does not.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1676997 - null check callback in PromiseJobRunnable::Suppressed(), r=mccr8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de5bd537b1d6
null check callback in PromiseJobRunnable::Suppressed(), r=mccr8

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/de5bd537b1d6