1677207 - Upgrade google_test version in NSS

Status: RESOLVED FIXED

(NSS :: Test, enhancement)

Description

[Kevin Jacobs [:kjacobs]]

Our GoogleTest version (1.8.1) is pretty old. The latest has GTEST_SKIP and some other nice-to-have features.

We should upgrade our dependency and use GTEST_SKIP where appropriate.

Comment 1

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Update Google Test to release-1.10.0

Comment 2

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Backport google_test 7d470772455112cfd1a0021f6853826d5e79af94

Depends on D98814

Comment 3

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Backport google_test 317ec2f296393ba30631e4ec2c7b3a6cbec08950

Depends on D98815

Comment 4

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Another ifdef fixup in google_test.

Depends on D98816

Comment 5

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Replace references to TestCase, which is deprecated, with TestSuite

grep -rl --exclude-dir=gtests/google_test/ INSTANTIATE_TEST_CASE_P gtests | xargs sed -i '' s/INSTANTIATE_TEST_CASE_P/INSTANTIATE_TEST_SUITE_P/g

Depends on D98817

Comment 6

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Build gtests with GTEST_REMOVE_LEGACY_TEST_CASEAPI_

Depends on D98818

Comment 7

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Use SetUpTestSuite in mozpkix_gtests, fix missing ssl_gtests include.

Depends on D98819

Comment 8

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1677207 - Use GTEST_SKIP in ssl_gtests.

Depends on D98820

Comment 9

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/rev/89141382df45ab72c8a6300c71f7634034370d18
https://hg.mozilla.org/projects/nss/rev/e15b78be87fad78ff262d06c4dd3e09efd59e3d2
https://hg.mozilla.org/projects/nss/rev/0772f1bf5fd6b68da79550c1b93fbab1db4f3acc