Closed Bug 1677244 Opened 4 years ago Closed 3 years ago

[macOS 11] YouTube will not go full screen if browser occupies the full display

Categories

(Core :: Widget: Cocoa, defect, P2)

Firefox 82
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- fix-optional

People

(Reporter: jackholexxxx, Unassigned)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [mac:fullscreen:native-affected][mac:fullscreen:nonnative-affected])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Firefox 82.0.3
MacOS 11.0.1

When watching a video on youtube.com or an embedded YouTube video from another site I cannot get full screen video when clicking the full screen button.

Actual results:

The screen goes black as if it is going to switch, but then reverts back to the normal player with the message "Full screen is unavailable".

Same issue in safe mode and with a fresh profile.

I discovered that if the browser is maximized to cover the entire display, full screen does not work. If I move any of the side edges (left or right) even a pixel or two inward, full screen works as expected.

Expected results:

YouTube video should go full screen.

Does this also happen if you try it on the regular YouTube website, i.e. not within an embedded YouTube frame? Does the display on which Firefox is shown have a menubar and/or a dock? Are you running this in a single screen or a multi screen environment?

With a single screen (and a visible menu bar) I cannot reproduce this on https://hacks.mozilla.org/2020/06/compiler-compiler-working-on-a-javascript-engine/ .

Blocks: 1648487
Status: UNCONFIRMED → NEW
Component: Untriaged → Widget: Cocoa
Ever confirmed: true
Product: Firefox → Core

It happens on both the YouTube website and other sites with embedded videos. This issue only popped up after upgrading to MacOS Big Sur.

My main computer is an iMac with a 5k display which I have mirrored to a 1080p TV (so both displays are running at 1920x1080). Being mirrored, the dock and menubar (which auto-hides) are on both displays. In my setup I do see the issue on the page you linked.

The menubar autohides? Oh, is the Firefox window in (native) full screen mode?

Yes, the menubar and dock both autohide. The window is not in native full screen, it is just manually sized to cover the entire display. I tried it in native full screen and YouTube full screen works as expected.

Oh wow, I just found the setting to auto-hide the menubar. I never knew you could do that!

However, even with that, I'm not able to reproduce this bug. But I'm using Firefox Nightly and macOS 11.0.1 Beta (20B5012d). I can try with Firefox Release next week.

With the same version of MacOS and Firefox, I can confirm that I am having the same issue as the OP. The option to view in full screen is only allowed if the browser window is not maximised.

Severity: -- → S3
Priority: -- → P2

Hi,

I was unable to reproduce this issue, I tested this on my end using the following configuration:

iMac (Retina 4K, 21.5-inch, 2019) with MacOS Big Sur 11.0.1
Firefox Release (82.0.3 and 83.0)
Firefox Nightly 84.0a1, 85.0a1

I tried different combinations:

  • Maximizing browser window and double-clicking to go full screen
  • Small size window (not maximized) and double-clicking to go full screen
  • Clicking on Picture in Picture and from there maximize window.
    The maximum quality configuration I can get on my machine is 1080p HD.

Regards,
Virginia

I'm able to replicate this issue when the menu and dock are hidden on the primary monitor or on any of the secondary monitors, which don't have a dock or menu screen.

MacOS Big Sur 11.1
Firefox Nightly 86.0a1

  • Brian Johnson

Just tried using AirCast on my home setup but to no luck.

@Ice/David/Jack any of you could double check with older builds (such as 45, 50, or 60) so we can confirm it's not a regression caused by Firefox patches?
Thanks!

Flags: needinfo?(jackholexxxx)
Flags: needinfo?(ice1138)
Flags: needinfo?(david.p.t.clark)

Full screen works fine in 45.9.0esr.
YouTube would not load on 50.0 or 60.0

This experiment really messed up my extensions so I probably will not be running test like this again.

Flags: needinfo?(jackholexxxx)

Should have suggested using profile manager, I apologise for that.
We might have luck with Ice/David, if they check with beta builds to get the regression range smaller.

In any case, the information you've provided is still useful and we thank you for that! Points toward an older patches that don't work well with mac11.

I re-ran the experiments using the profile manager and creating a new profile for each version (including the latest), choosing a random YouTube video each time.

50.0 - No issues
60.0 - No issues
84.0.2 - Will go full screen the first time, but all subsequent attempts fail

Could you run mozregression[1] to see when this started happening? If you have never run mozregression before, simply run these three commands in a Terminal window:

sudo easy_install pip
sudo python3 -m pip install -U mozregression --ignore-installed
mozregression --good 2017-01-01

A number of Firefox versions will open in succession to narrow down when this started occurring. Simply type "good" or "bad" in Terminal based on whether or not a build reproduces the bug. Once finished, please post the output from the last run. It should give a last good and first bad revision as well as a link to look at the changesets in that range. Thank you!

[1] https://mozilla.github.io/mozregression/

Flags: needinfo?(jackholexxxx)

(In reply to Stephen A Pohl [:spohl] from comment #13)

Could you run mozregression[1] to see when this started happening? If you have never run mozregression before, simply run these three commands in a Terminal window:

sudo easy_install pip
sudo python3 -m pip install -U mozregression --ignore-installed
mozregression --good 2017-01-01

A number of Firefox versions will open in succession to narrow down when this started occurring. Simply type "good" or "bad" in Terminal based on whether or not a build reproduces the bug. Once finished, please post the output from the last run. It should give a last good and first bad revision as well as a link to look at the changesets in that range. Thank you!

[1] https://mozilla.github.io/mozregression/

I get the following errors running your second command:

Building wheels for collected packages: glean-sdk, cffi, PyYAML, pyrsistent, MarkupSafe
  Building wheel for glean-sdk (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /Library/Developer/CommandLineTools/usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/pip-install-sqyqau69/glean-sdk/setup.py'"'"'; __file__='"'"'/private/tmp/pip-install-sqyqau69/glean-sdk/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /private/tmp/pip-wheel-ixp_0p6e --python-tag cp38
       cwd: /private/tmp/pip-install-sqyqau69/glean-sdk/
  Complete output (3 lines):
  running bdist_wheel
  running build
  error: [Errno 2] No such file or directory: 'cargo'
  ----------------------------------------
  ERROR: Failed building wheel for glean-sdk
  Running setup.py clean for glean-sdk
  Building wheel for cffi (setup.py) ... done
  Created wheel for cffi: filename=cffi-1.14.4-cp38-cp38-macosx_10_14_6_x86_64.whl size=257922 sha256=e3fe5a61e154c9293e893ceafe12b38d451767543787d6824531e6281d19ffe6
  Stored in directory: /Users/jackholexxxx/Library/Caches/pip/wheels/0b/5a/01/5220481b9a4717ba183b738c9ee7d773ad32548555a339345a
  Building wheel for PyYAML (setup.py) ... done
  Created wheel for PyYAML: filename=PyYAML-5.3.1-cp38-cp38-macosx_10_14_6_x86_64.whl size=44627 sha256=fd10330856ef484d17c0f22db9dd8c878c9af2cab0a3f8f1baa5451d790f2f56
  Stored in directory: /Users/jackholexxxx/Library/Caches/pip/wheels/a7/c1/ea/cf5bd31012e735dc1dfea3131a2d5eae7978b251083d6247bd
  Building wheel for pyrsistent (setup.py) ... done
  Created wheel for pyrsistent: filename=pyrsistent-0.17.3-cp38-cp38-macosx_10_14_6_x86_64.whl size=81373 sha256=a5412dfe8be15bb8a4cb2219416fc12e11eeb8846c3ccbb8479a7f5cb35e41e3
  Stored in directory: /Users/jackholexxxx/Library/Caches/pip/wheels/f0/b8/de/b593ad311be4eb458499d100db081e453576032272398b7ddc
  Building wheel for MarkupSafe (setup.py) ... done
  Created wheel for MarkupSafe: filename=MarkupSafe-1.1.1-cp38-cp38-macosx_10_14_6_x86_64.whl size=20106 sha256=406aeb5b1bd050f077fc48b870849d992ffdec4fddb93637cb3f514fb4481dbb
  Stored in directory: /Users/jackholexxxx/Library/Caches/pip/wheels/f2/aa/04/0edf07a1b8a5f5f1aed7580fffb69ce8972edc16a505916a77
Successfully built cffi PyYAML pyrsistent MarkupSafe
Failed to build glean-sdk
ERROR: aiohttp 3.7.3 has requirement chardet<4.0,>=2.0, but you'll have chardet 4.0.0 which is incompatible.
Installing collected packages: six, mozfile, distro, mozinfo, mozprocess, mozterm, blessings, mozlog, mozdevice, certifi, urllib3, idna, chardet, requests, redo, mozinstall, colorama, soupsieve, beautifulsoup4, mozprofile, mozrunner, mohawk, slugid, async-timeout, typing-extensions, attrs, multidict, yarl, aiohttp, taskcluster-urls, taskcluster, configobj, pycparser, cffi, pyrsistent, setuptools, jsonschema, MarkupSafe, Jinja2, pathspec, PyYAML, yamllint, diskcache, Click, appdirs, glean-parser, glean-sdk, mozversion, mozregression
  Running setup.py install for glean-sdk ... error
    ERROR: Command errored out with exit status 1:
     command: /Library/Developer/CommandLineTools/usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/pip-install-sqyqau69/glean-sdk/setup.py'"'"'; __file__='"'"'/private/tmp/pip-install-sqyqau69/glean-sdk/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-3q15874j/install-record.txt --single-version-externally-managed --compile
         cwd: /private/tmp/pip-install-sqyqau69/glean-sdk/
    Complete output (3 lines):
    running install
    running build
    error: [Errno 2] No such file or directory: 'cargo'
    ----------------------------------------
ERROR: Command errored out with exit status 1: /Library/Developer/CommandLineTools/usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/pip-install-sqyqau69/glean-sdk/setup.py'"'"'; __file__='"'"'/private/tmp/pip-install-sqyqau69/glean-sdk/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-3q15874j/install-record.txt --single-version-externally-managed --compile Check the logs for full command output.
WARNING: You are using pip version 19.2.3, however version 20.3.3 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

You might have better luck using the mozregression GUI. The installation instructions are here: https://mozilla.github.io/mozregression/install.html

(In reply to Stephen A Pohl [:spohl] from comment #15)

You might have better luck using the mozregression GUI. The installation instructions are here: https://mozilla.github.io/mozregression/install.html

Sorry, no luck with the GUI. It is showing "not responding" in activity monitor for 20+ minutes now while using 99.9% CPU.

Flags: needinfo?(jackholexxxx)

Does this work to install it?

pip install -U mozregression
Flags: needinfo?(jackholexxxx)

(In reply to Stephen A Pohl [:spohl] from comment #17)

Does this work to install it?

pip install -U mozregression
pip install -U mozregression
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
WARNING: The directory '/Users/jackholexxxx/Library/Caches/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Defaulting to user installation because normal site-packages is not writeable
Collecting mozregression
  Downloading mozregression-4.0.7.tar.gz (58 kB)
     |████████████████████████████████| 58 kB 1.8 MB/s 
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
ERROR: Package u'mozregression' requires a different Python: 2.7.16 not in '>=3.6'

Okay, there might be another way to install it that works for you on https://mozilla.github.io/mozregression/install.html.

Alternatively, if you have mozilla-central checked out, you could run mozregression via ./mach mozregression. Instructions to do so would be here: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

I finally got the mozregression commandline working, but builds 2017-01-01 53.0a1 and 2019-01-05 66.0a1 just came up with a white tab and no sites would load. I marked these good so I could continue the test.

Here are the results. I saved the entire log in case I did not copy enough info for you.

27:07.56 INFO: Narrowed integration regression window from [c8e9ecbc, 2ba20424] (4 builds) to [747fde9a, 2ba20424] (2 builds) (~1 steps left)
27:07.56 INFO: No more integration revisions, bisection finished.
27:07.56 INFO: Last good revision: 747fde9a723d8e4bf74bc2d3eb8e7b9af32b8006
27:07.56 INFO: First bad revision: 2ba20424fa166821be77c2f6a1d0458063200add
27:07.56 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=747fde9a723d8e4bf74bc2d3eb8e7b9af32b8006&tochange=2ba20424fa166821be77c2f6a1d0458063200add
Flags: needinfo?(jackholexxxx)

Thank you, this is exactly the output that was needed.

Xidorn, could you look into this regression from bug 1350875? Thank you

Flags: needinfo?(xidorn+moz)
Flags: needinfo?(ice1138)
Flags: needinfo?(david.p.t.clark)
Regressed by: 1350875
Has Regression Range: --- → yes

Sorry, but I don't have a machine with Big Sur powerful enough to build Firefox :(

I can reproduce this with Big Sur, though, and the fullscreen request seems to be rejected for

Request for fullscreen was denied because requesting element is not in the currently focused tab.

If this was regressed by bug 1350875, then the reason might be related to when the window covers the whole screen, the resize event never comes, and we finish fullscreen process from the timeout. I'm not sure why this can make the tab no longer focused, but it's probably a good start point to investigate.

Thank you, this is helpful input.

Flags: needinfo?(xidorn+moz)

(In reply to jackholexxxx from comment #12)

84.0.2 - Will go full screen the first time, but all subsequent attempts fail

Also this bug reproduced if checked 'Search for text when you start typing'.
If unchecked - full screen works fine.

Firefox 85.0.2 + 'full-screen-api.macos-native-full-screen:true', Big Sur 11.2.1

Whiteboard: [mac:fullscreen]

I was able to reproduce it on macOS 11.2.3, but unable to reproduce it on 10.15.7, with 88.0a1 (2021-03-17).

Easy steps to reproduce are:

  1. Hide menu bar and dock
  2. Manually stretch Firefox to cover all the screen
  3. Try to get a youtube video in fullscreen.

With 'full-screen-api.macos-native-full-screen:false' a message that fullscreen is rejected is shown
With 'full-screen-api.macos-native-full-screen:true' Firefox will enter fullscreen mode, and the same message that fullscreen for video not available is shown.

Summary: YouTube will not go full screen if browser occupies the full display → [macOS 11] YouTube will not go full screen if browser occupies the full display

I've the same issue. I'm wondering why it's not fixed yet. This looks like a important bug. Thanks!

Steps to reproduce:

  • Hide menu bar and dock
  • Manually stretch Firefox to cover all the screen
  • Try to get a youtube video in fullscreen.

just added a screenshot showing the error message

(In reply to x.shaiq from comment #26)

I've the same issue. I'm wondering why it's not fixed yet. This looks like a important bug. Thanks!

Steps to reproduce:

  • Hide menu bar and dock
  • Manually stretch Firefox to cover all the screen
  • Try to get a youtube video in fullscreen.

Just try this link:
https://bin.privacytools.io/?8d2e809264077758#9n4ukouodA83U16rWNAF3JamcWvNqxC4teSbD5Cz8XBG

:csasca, I tried to reproduce this problem with full-screen-api.macos-native-full-screen:true and that seems to work for me without the warning message. Can you please double-check if setting the pref solves the problem?

Flags: needinfo?(catalin.sasca)

Hey Martin, I did checked again on macOS 11, and here's an attachment with the actual behavior on my sistem.

Flags: needinfo?(catalin.sasca)

Hi,
I have noticed one behavior that enables the fullscreen mode on BigSur. Try to turn fullscreen on and make quickly "Mission Control" gesture (swipe three fingers up). Back to video. Hope it helps somehow to debug the issue.

Whiteboard: [mac:fullscreen] → [mac:fullscreen:native-affected][mac:fullscreen:nonnative-affected]

This issue seems to be resolved in 90.0. Thank you!

Thank you for letting us know!

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: