Closed
Bug 1677312
Opened 5 years ago
Closed 5 years ago
Directly encode/decode ParserAtomEntry at once
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(4 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D99650
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D99651
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/7a954fd0ec57
Part 1: Remove validation for TaggedParserAtomIndex in XDR. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/cdb90231cbe4
Part 2: Use uint32_t flag in ParserAtomEntry to make it packed. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/eca69583fbb3
Part 3: Encode/decode ParserAtomEntry content at once. r=tcampbell
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7a954fd0ec57
https://hg.mozilla.org/mozilla-central/rev/cdb90231cbe4
https://hg.mozilla.org/mozilla-central/rev/eca69583fbb3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
|
||
Comment 7•5 years ago
|
||
Re-opening to fix an alignment issue in another patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 8•5 years ago
|
||
When peeking the ParserAtomEntry header, use an explicit memcpy to allow
the compiler to decide if we should use unaligned access to the fields. At
the same time, rearange the code a bit to prepare for a future where we use
the ParserAtomEntry directly from the (then aligned) XDR buffer.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Attachment #9193537 -
Attachment description: Bug 1677312 - Avoid accessing unaligned XDR ParserAtom directly. r?arai! → Bug 1677312 - Part 4: Avoid accessing unaligned XDR ParserAtom directly. r?arai!
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4101c6211c7
Part 4: Avoid accessing unaligned XDR ParserAtom directly. r=arai
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•