Fix contrast for [Manage bookmarks...] link on dark themes
Categories
(Firefox :: Bookmarks & History, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox83 | --- | unaffected |
firefox84 | --- | verified |
firefox85 | --- | verified |
People
(Reporter: cfogel, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
6.44 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- 84.0a1(2020-11-15)
Affected platforms
- macOS 10.15, Windows 10;
Steps to reproduce
- Firefox, OS theme set to dark;
- Launch Firefox with a fresh profile;
- Open the Customize window and remove Default items from the bookmarks toolbar;
- Open a new tab;
Expected result
- Manage bookmarks option is displayed on the new section;
**Enhancement suggestion **
- change the color or the string to a lighter shade of blue;
Regression range
- last "good": 2020-11-13;
- first "bad": 2020-11-14
- Pushlog URL
- not a regressed behavior, introduced with patch from bug 1674091;
Additional notes
- S4 as suggested severity;
- attached screenshot with the issue, not the best one; will update it once I can trigger that menu again;
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
Reporter | ||
Comment 2•4 years ago
|
||
Updated steps and regression range.
Comment 3•4 years ago
|
||
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
We have specs on dark-bg link text right? Is it just a question of this being the first one in browser chrome? :ntim, do you know?
We could probably uplift a fix, as it should just be a single line of CSS...
Comment 5•4 years ago
|
||
(In reply to :Gijs (he/him) from comment #4)
We have specs on dark-bg link text right?
For in-content pages: the spec was --blue-50 (#0a84ff) all the time before, but for more ideal contrast all the time, it's now --blue-40 (#45a1ff) for the dark theme, --blue-60 (#0060df) for the light theme.
Is it just a question of this being the first one in browser chrome? :ntim, do you know?
This is the first one in the toolbar area. There are some in arrow panels or the urlbar popup though.
To fix this with a single CSS rule, we should keep -moz-nativehyperlinktext (good for HCM) for the default theme (so nothing to add here), and add this:
:is(#nav-bar, #PersonalToolbar):-moz-lwtheme .text-link {
color: #0a84ff;
}
Uses --blue-50 all the time for links on the toolbar which looks OK in most situations. There's no way to get whether the text is dark or light on the #navbar/#PersonalToolbar areas specifically (they can differ from the #TabsToolbar area), but you could add one if you really want (lwt-popup-brighttext is a good example how).
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 9190929 [details]
Bug 1677425 - improve link colours in the navbar and bookmarks toolbar, r?ntim,jaws
Beta/Release Uplift Approval Request
- User impact if declined: Links are hard to read on dark themes
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This adds 2 CSS rules to improve link colouring for themes
- String changes made/needed: nope
Assignee | ||
Updated•4 years ago
|
Comment 9•4 years ago
|
||
Comment on attachment 9190929 [details]
Bug 1677425 - improve link colours in the navbar and bookmarks toolbar, r?ntim,jaws
Approved for 84.0b8.
Comment 10•4 years ago
|
||
bugherder uplift |
Comment 11•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Reproduced the initial issue on Nightly 84.0a1 and Beta 83.0b9.
Verified fixed on latest Nightly version 85.0a1 (2020-12-04) and Beta version 84.0b8 on Windows 10 and macOS 10.15.
Description
•