1677427 - remove <grid> usage from openpgp

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, task, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1521483 +++

There's still a small amount of <grid> in the openpgp code: https://searchfox.org/comm-central/search?q=enigmailKeyImportInfo.js&path=mail&case=false&regexp=false

It's also apparently using top level <dialog>...

The dialog is pretty horrible, so we could try to fix the appearance at least a bit while we're here.

<grid> will very soon be removed from m-c now.

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1677427_remove-grid-openpgp-0.patch

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1677427_remove-grid-openpgp-1.patch

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1677427_remove-grid-openpgp-2.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9188987 [details] [diff] [review]
Bug-1677427_remove-grid-openpgp-2.patch

Review of attachment 9188987 [details] [diff] [review]:
-----------------------------------------------------------------

The title "Success! Keys imported" is no longer set.

Other than that,  this whole dialog is so strange and confusing I don't even know where to begin... but that's out of scope for this bug.

::: mail/extensions/openpgp/content/ui/enigmailKeyImportInfo.js
@@ +69,4 @@
>  
>    if (keys.length) {
>      let keysInfoBox = document.getElementById("keyInfo"),
> +      keyBox = document.createXULElement("vbox");

please declare each separeately, not with commas

@@ +73,3 @@
>  
> +    keyBox.classList.add("grid-three-column");
> +    for (i = 0; i < keys.length; i++) {

would declare i here, but even better use for (let key of keys)

@@ +125,1 @@
>    for (i = 0; i < keyObj.fpr.length; i += 4) {

declare i here in the loop

::: mail/themes/shared/openpgp/enigmail-common.css
@@ +89,4 @@
>    border-style: groove;
>    border-width: thin;
>    padding: 3px;
> +  margin: 10px 3px;

also afffecting enigmailKeygen.xhtml. Not sure we want that

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1677427_remove-grid-openpgp-3.patch

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9189129 [details] [diff] [review]
Bug-1677427_remove-grid-openpgp-3.patch

Review of attachment 9189129 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/extensions/openpgp/content/ui/enigmailKeyImportInfo.xhtml
@@ +21,3 @@
>          xmlns:html="http://www.w3.org/1999/xhtml">
> +<dialog id="enigmailKeyImportInfo"
> +        buttons="accept,help,cancel,extra1,extra2">

ok so we only ever use accept, and manually hide all the others, never to be shown. 
Maybe we can fix that while we're here.

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: Bug-1677427_remove-grid-openpgp-4.patch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2bfa9ffc8c69
Remove grid usage from openpgp. r=mkmelin