Closed Bug 1677432 Opened 4 years ago Closed 4 years ago

mozlint/license: testing/ is ignored

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

Because the heuristics to detect if we are dealing with a test aren't great...

https://searchfox.org/mozilla-central/source/tools/lint/license/__init__.py#79

We were not managing /testing/ because /test was catching it

Depends on D97135

Assignee: nobody → sledru
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59fc06b10800 mozlint/license: be more precriptive in the tests detection r=linter-reviewers,ahal

Backed out for license failures.

backout: https://hg.mozilla.org/integration/autoland/rev/cce64b6bd741936cbdc0e532adb61d0ea174a7f2

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=FYz4ljxHTc6FNDvMnBAvYA.0&searchStr=linting%2Copt%2Cpedantic%2Cchecks%2Csource-test-mozlint-license%2Clicense&revision=59fc06b10800dea1dd0477a37495e9b2265dd64b

failure log: https://treeherder.mozilla.org/logviewer?job_id=321985901&repo=autoland&lineNumber=123

[task 2020-11-16T23:45:38.118Z] /builds/worker/checkouts/gecko/image
[task 2020-11-16T23:45:51.796Z] 23:45:51.796 license (91) | Finished in 13.86 seconds
[task 2020-11-16T23:45:51.904Z] 23:45:51.903 license (89) | Finished in 13.97 seconds
[task 2020-11-16T23:45:57.537Z] 23:45:57.536 license (88) | Finished in 19.61 seconds
[task 2020-11-16T23:46:41.304Z] 23:46:41.304 license (90) | Finished in 63.37 seconds
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/shared/test-helpers/.eslintrc.js:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/awsy/awsy/init.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/condprofile/condprof/customization/init.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/condprofile/condprof/scenarii/init.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/condprofile/condprof/scenarii/full.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/condprofile/condprof/scenarii/settled.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/condprofile/condprof/scenarii/settled2.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/condprofile/setup.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/firefox-ui/resources/cookies/cookie_single.html:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2020-11-16T23:46:41.315Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/firefox-ui/resources/layout/mozilla.html:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9e8d121c4a1a mozlint/license: be more precriptive in the tests detection r=linter-reviewers,ahal

Lando didn't land everything.
Should be fixed now.

Flags: needinfo?(sledru)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: