1677521 - Add a different way for OCSP channels to use TRR_DISABLED_MODE

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

Bug 1666072 had to disable the test because it assumes only OCSP channels call SetAllowSTS(false) - but the same bug also makes captive portal channels perform the same call.

We need a separate method that only gets called by OCSP channels after calling SetAllowSTS(false) that optionally

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1677521 - Enable test_trr.js::test25e r=#necko

This test was disabled in Bug 1666072 when we set the allowSTS=false for
captive portal requests to prevent a HSTS upgrade redirect.

Bug 1681683 added a different property (isOCSP) to be able to differentiate
OCSP channels from regular ones, so even if captive portal channels have
allowSTS=false, they still use the same TRR mode as was initially set
on the channel. This means the test will now work in mode3 as well.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10b44c471ac7
Enable test_trr.js::test25e r=necko-reviewers,kershaw

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/10b44c471ac7