1677657 - Make js::BaseScript::{extent,immutableFlags} const

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

By tweaking how MakeDefaultConstructor works to instead plumb the SourceExtent down to the cloning code, we can make the BaseScript::extent const. Probably can also make the ImmutableFlags const too after the TI removal.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1677657 - Directly set SourceExtent when cloning default class constructor. r?jandem!

While cloning the default constructor script from self-hosting realm, pass in
the final SourceExtent for the class. This removes the last need for the
BaseScript::extent to be modified so we can now mark it const.

Also clear the script's SelfHosted flag in the same way to avoid modifying it
after the script is created.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/293b759748b9
Directly set SourceExtent when cloning default class constructor. r=jandem

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/293b759748b9