1677688 - Avoid nested property bags in Places async shutdown metadata

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, task, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Most of the metadata looks like:
"state":{"progress":{},"Barrier":{}}
That is quite useless. I think it's due to our use of nested property bags, thus here I'd like to change the approach copying over variants from the original property bag to the final one, hopefully we'll get better logging.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1677688 - Avoid nested property bags in Places async shutdown metadata. r=standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bdcf54531e1
Avoid nested property bags in Places async shutdown metadata. r=Standard8

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8bdcf54531e1

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This has been backed out for crashes with [@ mozilla::places::PlacesShutdownBlocker::GetState], e.g. bp-181e28bc-2c23-4598-b4d7-8c7cd0201121

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/31395a8cf477
Backed out changeset 8bdcf54531e1 for crashes. a=backout DONTBUILD

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Do you remember if the crashes were visible on treeherder? Trying to check how I can reproduce them easily.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This hasn't be observed in our automation, only on the user side. Most of the uptimes were several hours.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceb70463432e
Avoid nested property bags in Places async shutdown metadata. r=Standard8

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ceb70463432e