1677715 - Changes to support pipewire broke moz.build code generation

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Dan Minor [:dminor]]

I missed this during review, but Martin was not aware that the moz.build files are code generated from BUILD.gn files and edited them directly. It is not possible to generate correct moz.build files from the BUILD.gn files for desktop_capture at the moment. This has broken the libwebrtc build for FreeBSD (Bug 1676134) and caused problems while doing the libwebrtc update (Bug 1654112).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1672989

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1677715 - Add a way of setting TK_CFLAGS in a gn generated moz.build file

This adds write_mozbuild_variables to the GnProjectData that can be used to
configure code generation of moz.build files. This is done to support adding
CONFIG["TK_CFLAGS"] to INCLUDES for gtk builds, which is necessary to support
pipewire.

There is likely a more elegant way of handling this, but since we plan to
remove code generation of moz.build files in the near future anyway, I'm not
sure it is worth investing more time than a minimal amount of time in this.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1677715 - Set write_mozbuild_vars for libwebrtc; r=ng!

This sets the write_mozbuild_vars for libwebrtc to include TK_CFLAGS for
desktop_capture.

Depends on D97427

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1677715 - Set rtc_use_pipewire flag in webrtc.gni; r=ng!

This enables rtc_use_pipewire for libwebrtc as a whole. We should fallback
to X11 screen capture on non-Wayland systems.

Depends on D97428

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1677715 - Fixup errors in desktop_capture BUILD.gn; r=ng!

Depends on D97429

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1677715 - Build libpipewire as a dependency of libwebrtc; r=ng!

Depends on D97430

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1677715 - Update gn generated json files for tier-1 platforms; r=ng!

Depends on D97431

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1677715 - Regenerate moz.build files; r=ng!

Depends on D97432

Comment 9

[Dan Minor [:dminor]]

Try job here: https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=OoIsqQLqQmidVwrDH3E0Jg.0&revision=f814933a783481bd4ba898660067f81311add5b6

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ab2dc45e3f1
Add a way of setting TK_CFLAGS in a gn generated moz.build file r=firefox-build-system-reviewers,mhentges,ng
https://hg.mozilla.org/integration/autoland/rev/1da93acd5a21
Set write_mozbuild_vars for libwebrtc; r=ng
https://hg.mozilla.org/integration/autoland/rev/96935994bcca
Set rtc_use_pipewire flag in webrtc.gni; r=ng
https://hg.mozilla.org/integration/autoland/rev/6fb2ffeb035b
Fixup errors in desktop_capture BUILD.gn; r=ng
https://hg.mozilla.org/integration/autoland/rev/f6baf18918aa
Build libpipewire as a dependency of libwebrtc; r=ng
https://hg.mozilla.org/integration/autoland/rev/085eb2aa64c8
Update gn generated json files for tier-1 platforms; r=ng
https://hg.mozilla.org/integration/autoland/rev/2c1390ba3315
Regenerate moz.build files; r=ng

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0ab2dc45e3f1
https://hg.mozilla.org/mozilla-central/rev/1da93acd5a21
https://hg.mozilla.org/mozilla-central/rev/96935994bcca
https://hg.mozilla.org/mozilla-central/rev/6fb2ffeb035b
https://hg.mozilla.org/mozilla-central/rev/f6baf18918aa
https://hg.mozilla.org/mozilla-central/rev/085eb2aa64c8
https://hg.mozilla.org/mozilla-central/rev/2c1390ba3315

Comment 12

[Landry Breuil (:gaston)]

is this a candidate for backport to 84, if not too late ?

Comment 13

[Dan Minor [:dminor]]

Unfortunately, I think it is too late for a backport for 84. You might consider making a local patch for the bad moz.build file for 84, which you could then drop for 85. Sorry about this!