1677723 - Telemetry pings are not displayed in Browser Console for simple snippets

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Rares Doghi, Desktop QA]

[Affected versions]
Firefox 84.0b1

[Affected platforms]
ALL

[Preconditions]
Have the following prefs in the "about:config" page:
Have the "browser.ping-centre.log" set to "true"
Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page.

[Steps to reproduce]

1. Open the Firefox browser and reach about:newtab#devtools
2. Open Browser Console.
3. From the "about:newtab#devtools" page scroll to the "SIMPLE_TEST_1" snippet.
4. Click the "Show" button.
5. From the Displayed Snippet at the bottom of the page Click the "X" Close button.

[Expected result]
A Telemetry ping should be displayed in Browser console for both actions : "Show" as well as "Close"

[Actual result]
There are no Telemetry pings displayed for either action. The Telemetry ping is only displayed when the user clicks the Link from the Snippet.

Comment 1

[Rares Doghi, Desktop QA]

I Think the severity for this issue should be an S3.

This seems to be a regression, I will try to get a regression range for this issue as soon as possible.

Comment 2

[Rares Doghi, Desktop QA]

I was able to get a First Bad build and a Last known Good build manually downloading builds from the archive and these are the results:

Last Known Good: https://hg.mozilla.org/mozilla-central/rev/03de9a8a6f7c949b046b5a1197988391ede9e84f
First Known Bad: https://hg.mozilla.org/mozilla-central/rev/dafa26b89edacc8d9fb9eade704d7124ba5239cf

I'm not sure which of these issues could have caused the this issue but please take a look:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=03de9a8a6f7c949b046b5a1197988391ede9e84f&tochange=dafa26b89edacc8d9fb9eade704d7124ba5239cf

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Bug 1677723 - Telemetry pings are not sent for Snippets

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b12f5962b9d2
Telemetry pings are not sent for Snippets r=nanj

Comment 5

[Andrei Oprea [:andreio]]

[Tracking Requested - why for this release]: Bug causes issue in telemetry that prevents pings from being sent.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b12f5962b9d2

Comment 7

[Andrei Oprea [:andreio]]

Comment on attachment 9190295 [details]
Bug 1677723 - Telemetry pings are not sent for Snippets

Beta/Release Uplift Approval Request

• User impact if declined: No user impact but we would lose telemetry pings from some of our components.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch for something that is not user facing
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9190295 [details]
Bug 1677723 - Telemetry pings are not sent for Snippets

Approved for 84.0b7.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2eb321343d57

Comment 10

[Rares Doghi, Desktop QA]

This issue is Verified as Fixed in our latest Nightly build 85.0a1 (2020-12-01) as well as our Latest Beta 84.0b7 on Windows 10, MacOsx 10.15 and Ubuntu 20.04