Closed
Bug 1677775
Opened 5 years ago
Closed 2 years ago
Run black on .mozbuild files
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox122 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox122 | --- | fixed |
People
(Reporter: away, Assigned: Logan)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
This file doesn't appear to use black's style: https://searchfox.org/mozilla-central/source/js/src/js-cxxflags.mozbuild
I assume it's because we don't consider .mozbuild
files, but it's a reasonably common idiom: https://searchfox.org/mozilla-central/search?q=.mozbuild
Updated•4 years ago
|
Severity: -- → S4
Priority: -- → P3
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → loganrosen
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•2 years ago
|
||
Depends on D193005
Assignee | ||
Comment 3•2 years ago
|
||
#ignore-this-changeset
Depends on D193006
Pushed by loganrosen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2ab88a63f92e
adjust ICU .mozbuild generation format to work with Black r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/7f982566b9a9
reformat .mozbuild files with Black r=linter-reviewers,geckoview-reviewers,firefox-build-system-reviewers,ahal,glandium,owlish,sylvestre
https://hg.mozilla.org/integration/autoland/rev/a42c871d1585
enable Black on .mozbuild files r=linter-reviewers,firefox-build-system-reviewers,ahal,glandium
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2ab88a63f92e
https://hg.mozilla.org/mozilla-central/rev/7f982566b9a9
https://hg.mozilla.org/mozilla-central/rev/a42c871d1585
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Updated•2 years ago
|
Type: defect → enhancement
You need to log in
before you can comment on or make changes to this bug.
Description
•