Closed Bug 1677775 Opened 5 years ago Closed 2 years ago

Run black on .mozbuild files

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement, P3)

enhancement

Tracking

(firefox122 fixed)

RESOLVED FIXED
Tracking Status
firefox122 --- fixed

People

(Reporter: away, Assigned: Logan)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

This file doesn't appear to use black's style: https://searchfox.org/mozilla-central/source/js/src/js-cxxflags.mozbuild

I assume it's because we don't consider .mozbuild files, but it's a reasonably common idiom: https://searchfox.org/mozilla-central/search?q=.mozbuild

Severity: -- → S4
Priority: -- → P3
Product: Firefox Build System → Developer Infrastructure
Assignee: nobody → loganrosen
Status: NEW → ASSIGNED

#ignore-this-changeset

Depends on D193006

Pushed by loganrosen@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2ab88a63f92e adjust ICU .mozbuild generation format to work with Black r=hsivonen https://hg.mozilla.org/integration/autoland/rev/7f982566b9a9 reformat .mozbuild files with Black r=linter-reviewers,geckoview-reviewers,firefox-build-system-reviewers,ahal,glandium,owlish,sylvestre https://hg.mozilla.org/integration/autoland/rev/a42c871d1585 enable Black on .mozbuild files r=linter-reviewers,firefox-build-system-reviewers,ahal,glandium
Type: defect → enhancement
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: