1677819 - printing calendar do not work - Uncaught TypeError: window.arguments is undefined

Status: RESOLVED FIXED

(Calendar :: Printing, defect, P1)

Description

[WaltS48 [:walts48]]

Attachment: console-export-2020-11-17_14-22-15.txt

Calendar printing doesn't work my test of the Thunderbird 84.0b1 release candidate on Ubuntu 18.04 Linux.

Selected the Calendar Tab.
Selected File > Print.
Left List as the Layout.
Entered Test for the Title.
Left the default selections enabled.
Clicked Print.
Progress dialog come up, but nothing prints.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: 1677819.patch

This is similar to https://searchfox.org/comm-central/rev/8783b24ad5915927163977ea19a9968659b90d4c/mailnews/base/content/msgPrintEngine.js#30-31 by bug 1662090.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9190739 [details] [diff] [review]
1677819.patch

Review of attachment 9190739 [details] [diff] [review]:
-----------------------------------------------------------------

Works, thanks! r=mkmelin

::: calendar/base/content/dialogs/calendar-print-dialog.js
@@ +26,5 @@
>  /**
>   * Loads the print dialog, setting up all needed elements.
>   */
>  function loadCalendarPrintDialog() {
> +  // This is need to pass down browserDOMWindow to msgPrintEngine window.

This is needed

Maybe
// This is needed since msgPrintEngine.js expects it.

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: 1677819.patch

Update comment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dad76f5bde13
Fix printing calendar. r=mkmelin