1677836 - Pref off highlights on New Tab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Erica Wright [:ewright]]

We will be turning off the Highlights by default, on the new tab for all users. Users can still edit this in about:preferences, or in the soon-to-be-added customize menu on new tab.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1677836 - Default off highlights section on New Tab.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21a42dc685e6
Default off highlights section on New Tab. r=Mardak

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_policy_firefoxhome.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f19cd587d326b8a42bda36a7befff6e77f11a26b
Log link: https://treeherder.mozilla.org/logviewer?job_id=322361380&repo=autoland&lineNumber=7895

Comment 4

[Narcis Beleuzu [:NarcisB]]

Please also check failures on browser_sma_configure_homepage.js
https://treeherder.mozilla.org/logviewer?job_id=322379531&repo=autoland&lineNumber=19816

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7b2ba61bdd9
Default off highlights section on New Tab. r=Mardak

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f7b2ba61bdd9

Comment 7

[Andra Esanu (needinfo me)]

== Change summary for alert #27847 (as of Tue, 24 Nov 2020 12:43:32 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
2%	JS		macosx1014-64-shippable-qr		81,348,070.18 -> 79,670,101.62
2%	Images		linux1804-64-shippable-qr		4,719,751.10 -> 4,625,089.92
2%	JS		linux1804-64-shippable-qr		79,128,398.92 -> 77,542,936.39
2%	JS		linux1804-64-shippable-qr		78,754,774.40 -> 77,516,797.01

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27847

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue and I can confirm that that the "Highlights" section is no longer displayed on the "New Tab" page, but it can be successfully added from the "about:preferences#home" page.

Verified using the latest Firefox Nightly (85.0a1 Build ID - 20201123214551) installed on Windows 10 x64, Linux Mint 20 x64, and Mac 10.15.

Comment 9

[Erica Wright [:ewright]]

Comment on attachment 9188411 [details]
Bug 1677836 - Default off highlights section on New Tab.

Beta/Release Uplift Approval Request

• User impact if declined: we believe highlights is no longer a good default UI and would like to have it removed as the default option.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): a single pref flip
• String changes made/needed: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9188411 [details]
Bug 1677836 - Default off highlights section on New Tab.

Approved for 84.0b7.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e767461ce41f

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that that the "Highlights" section is no longer displayed on the "New Tab" page, but it can be successfully added from the "about:preferences#home" page.

Verified using the latest Firefox Beta (84.0b7 Build ID - 20201201213706) installed on Windows 10 x64, Linux Mint 20 x64, and Mac 10.15.