1677838 - NumberFormatExceptionjava.lang.Integer in parseInt fatal for input string: "undefined"

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P1)

Description

[Arturo Mejia [:amejia]]

We are seeing these crash being reported on sentry multiple times

Fenix related issue https://github.com/mozilla-mobile/fenix/issues/16623
Sentry crash https://sentry.prod.mozaws.net/operations/firefox-nightly/issues/9812825/

java.lang.NumberFormatException: For input string: "undefined"
    at java.lang.Integer.parseInt(Integer.java:615)
    at java.lang.Integer.valueOf(Integer.java:801)
    at org.mozilla.geckoview.MediaSession$Metadata.fromBundle(MediaSession.java:16)
    at org.mozilla.geckoview.MediaSession$Handler.handleMessage(MediaSession.java:9)
    at org.mozilla.geckoview.MediaSession$Handler.handleMessage(MediaSession.java:1)
    at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:2)
    at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:1)
    at android.os.Handler.handleCallback(Handler.java:883)
    at android.os.Handler.dispatchMessage(Handler.java:100)
    at android.os.Looper.loop(Looper.java:214)
    at android.app.ActivityThread.main(ActivityThread.java:7682)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:516)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Eugen, any ideas?

Comment 2

[Eugen Sawin [:esawin]]

The line numbers in the stack trace are garbage and the stack seems incomplete.
Since on this path, we only use Integer.valueOf in ImageResource sizes parsing, I assume we're encountering invalid size strings and fail when trying to make them fit the <int>x<int> format.
Let's ignore those invalid size strings.

Comment 3

[Eugen Sawin [:esawin]]

Attachment: Bug 1677838 - [1.1] Verify the image resource size string is valid before accepting it.

Comment 4

[Eugen Sawin [:esawin]]

Filed bug 1681352 to investigate a Gecko/DOM validation solution.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e764199bb911
[1.0] Verify the image resource size string is valid before accepting it. r=geckoview-reviewers,agi

Comment 6

[Razvan Maries]

Backed out for Lint failure.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Ciz5d4-dSXeJvtsyg2gmhw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=e764199bb91165b42250421fa8c421a104f0ffdf

Log: https://treeherder.mozilla.org/logviewer?job_id=323962961&repo=autoland&lineNumber=1051

Backout: https://hg.mozilla.org/integration/autoland/rev/ead7d0785911a5b59e2490c1d95db7810e3851f4

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac5832465c28
[1.1] Verify the image resource size string is valid before accepting it. r=geckoview-reviewers,agi

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ac5832465c28

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Crashes on cnn.com live video. If we have not pushed the buttons for 84.1.4 this seems like a good ridealong.

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

Comment on attachment 9189236 [details]
Bug 1677838 - [1.1] Verify the image resource size string is valid before accepting it.

Beta/Release Uplift Approval Request

• User impact if declined: Crash when opening cnn.com and other pages
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mostly adding a try { } catch block and ignoring bad data, patch has been in nightly and beta for a while
• String changes made/needed: N/A

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9189236 [details]
Bug 1677838 - [1.1] Verify the image resource size string is valid before accepting it.

Approved for Fenix 84.1.4.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/2d66edf05e1309134393aa0df75b444eb47ae324

Comment 14

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.