1677856 - template string not terminated when containing optional chaining

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect)

Description

[matze.kind]

Attachment: debugger questionmark template error.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Have a template string with optional chaining inside, e.g.
const a = asdf${a?.b}1234

Look at the code iIn the debugger view

Actual results:

the closing curly bracket is not beeing detected as the terminator for the JS part, so any code that follows that statement is displayed in blue (as string content).

Expected results:

the closing curly bracket should terminate the js part and the next ` the template string, so that the following code is parsed as code

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

I can reproduce the problem on my machine (Win10, Nightly)

@Hubert, could this be CodeMirror issue?

Honza

Comment 3

[Hubert Boma Manilla (:bomsy)]

Thanks Honza.

Yeah ... looks like it.
i filed an issue
https://github.com/codemirror/CodeMirror/issues/6500

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1677856 - [devtools] Update codemirror javascript mode r=nchevobbe

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dc5333dfc77
[devtools] Update codemirror javascript mode r=nchevobbe

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3dc5333dfc77