1677959 - Update org.freedesktop.Platform to 20.08

Status: VERIFIED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[jakob.jakobson13]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Install the firefox flatpak package and check the installed flatpak packages.

Actual results:

Firefox depends on org.freedesktop.Platform//19.08 even though org.freedesktop.Platform//20.08 was released.

Expected results:

Firefox depends on the newest org.freedesktop.Platform//20.08 release.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

I think this should be straightforward by just bumping.

1. the docker we're pulling from in building the repackage job - https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/docker/firefox-flatpak/Dockerfile#l1
2. the Freedesktop version in https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/docker/firefox-flatpak/runme.sh that's used in baking the flatpak we publish.

Note to self: I should double-check with :barthalion that there aren't any other bumps on server side that we'd need.

Comment 2

[Emerson Bernier]

You also need the baseapp to be updated: https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/16

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Emerson Bernier from comment #2)

You also need the baseapp to be updated: https://github.com/flathub/org.mozilla.Firefox.BaseApp/pull/16

Ah, good catch, thank you! Do you know if there's a timeframe for that PR to land and be deployed?

Comment 4

[Emerson Bernier]

AFAIK nothing blocks it except there was no signal from mozilla about the need for upgrade. You may just ping barthalion and he should merge it.

Comment 5

[Emerson Bernier]

baseapp is updated now so flathub side should be ready for ff runtime bump.

Comment 6

[Seppo Yli-Olli]

TLDR; FIREFOX_BASEAPP_CHANNEL now follows FREEDESKTOP_VERSION.

Note that 19.08 base app was not properly following ABI stability best practices on flatpak. Starting with 20.08 the base app version and runtime version version will be identical (there will be a different base app for every). Firefox release channel itself will remain unmodified. The reason for this is that runtime version needs to be independently defined for the base app and Firefox app and to be able to have the stable ABI promise, Firefox app must also change to runtime in same build as when it starts using base app that uses new runtime. There should not be a pressing reason to update to newer docker image although it can be done.

Comment 7

[Bartłomiej Piotrowski]

Attachment: Bug 1677959 - upgrade freedesktop-sdk runtime to 20.08 r=mtabara

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/658693414024
upgrade freedesktop-sdk runtime to 20.08 r=mtabara

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa27be7175639d6aaf9aaf70106df79d9e0ffe09

Uplifted to beta, will let Sheriffs merge this to central.
Thank you again for this patch @barthalion! \o/

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/658693414024

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/658693414024

Comment 12

[Mihai Tabara [:mtabara]⌚️GMT]

https://firefox-ci-tc.services.mozilla.com/tasks/Q2K7H7ANSPWOlAkZkLUb8g worked like a charm in last night's beta!