1677969 - Places Expiration should not run a query on startup

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P3)

Description

[Marco Bonardo [:mak]]

This runs as soon as the service is inited
https://searchfox.org/mozilla-central/rev/277ab3925eae21b419167a34624ec0ab518d0c94/toolkit/components/places/PlacesExpiration.jsm#843-846

I think this is not necessary, we can make it lazier

Comment 1

[Marco Bonardo [:mak]]

Also from the logs in Bug 1675461 it looks like notify is starting sooner than expected, and in the middle of responsiveness tests. We should use idle better.
Bug 1475582 is probably also relevant.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1677969 - Places Expiration should not run queries on startup. r=adw

Don't run queries immediately when reading prefs on startup, rather use a lazy
getter when necessary.
Wrap the whole notify call in the idle callback.
Use the concurrent promiseDBConnection to read page counts, so it doesn't block.
Use withConnectionWrapper to address the missing shutdown blocker when
expiration runs.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91656bfde225
Places Expiration should not run queries on startup. r=adw

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/91656bfde225