1678030 - Reduce code duplication around mozIStorageStatement

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1678030 - Move CreateAndExecuteSingleStepStatement to QuotaCommon and use in all quota clients. r=#dom-workers-and-storage

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1678030 - Support multiple variants of hasResult expectations in CreateAndExecuteSingleStepStatement. r=#dom-workers-and-storage

Depends on D97460

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1678030 - Generalize CreateAndExecuteSingleStepStatement to accept an optional bind functor. r=#dom-workers-and-storage

Depends on D97461

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1678030 - Introduce LazyStatement class. r=#dom-workers-and-storage

Depends on D97462

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1678030 - Introduce LazyStatement::BorrowAndExecuteSingleStep function. r=#dom-workers-and-storage

Depends on D97463

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1678030 - Add DatabaseConnection::BorrowAndExecuteSingleStepStatement function. r=#dom-workers-and-storage

Depends on D97464

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1678030 - Move CollectWhileHasResult to QuotaCommon and use in other quota clients.

Depends on D97465

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ed5e139d784
Move CreateAndExecuteSingleStepStatement to QuotaCommon and use in all quota clients. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/2fb182664097
Support multiple variants of hasResult expectations in CreateAndExecuteSingleStepStatement. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/dc0c88b81dc2
Generalize CreateAndExecuteSingleStepStatement to accept an optional bind functor. r=dom-workers-and-storage-reviewers,ttung

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2ed5e139d784
https://hg.mozilla.org/mozilla-central/rev/2fb182664097
https://hg.mozilla.org/mozilla-central/rev/dc0c88b81dc2

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/659b97e784bf
Introduce LazyStatement class. r=dom-workers-and-storage-reviewers,ttung

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/659b97e784bf

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5dbd1090f2e
Introduce LazyStatement::BorrowAndExecuteSingleStep function. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/48a9523329f2
Add DatabaseConnection::BorrowAndExecuteSingleStepStatement function. r=dom-workers-and-storage-reviewers,ttung

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b5dbd1090f2e
https://hg.mozilla.org/mozilla-central/rev/48a9523329f2

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0287f5604a69
Move CollectWhileHasResult to QuotaCommon and use in other quota clients. r=dom-workers-and-storage-reviewers,ttung

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0287f5604a69

Comment 16

[Mathew Hodson]

The leave-open keyword was set, but I think this bug can be closed now right?

Comment 17

[Simon Giesecke [:sg] [he/him]]

(In reply to Mathew Hodson from comment #16)

The leave-open keyword was set, but I think this bug can be closed now right?

Right, thanks for catching that!