1678070 - License lints expects to see .hg, fails with a git-cinnabar checkout

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Henri Sivonen (:hsivonen)]

With a cinnabar checkout, this happens:

$ ./mach lint --warnings --outgoing
Error running mach:

    ['lint', '--warnings', '--outgoing']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file lint| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

mozlint.errors.LinterParseError: tools/lint/license.yml: The exclude directive contains the following paths that don't exist:
  .hg

  File "/opt/Projects/gecko/tools/lint/mach_commands.py", line 94, in lint
    return cli.run(*runargs, **lintargs)
  File "/opt/Projects/gecko/python/mozlint/mozlint/cli.py", line 286, in run
    lint.read(find_linters(lintargs["config_paths"], linters))
  File "/opt/Projects/gecko/python/mozlint/mozlint/roller.py", line 184, in read
    for linter in chain(*[self.parse(p) for p in paths]):
  File "/opt/Projects/gecko/python/mozlint/mozlint/roller.py", line 184, in <listcomp>
    for linter in chain(*[self.parse(p) for p in paths]):
  File "/opt/Projects/gecko/python/mozlint/mozlint/parser.py", line 31, in __call__
    return self.parse(path)
  File "/opt/Projects/gecko/python/mozlint/mozlint/parser.py", line 125, in parse
    self._validate(linter)
  File "/opt/Projects/gecko/python/mozlint/mozlint/parser.py", line 80, in _validate
    raise LinterParseError(
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

Expected not to have to do touch .hg

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1678070 - mozlint/license: remove .hg from the exclude list r#linter-reviewers, hsivonen

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3b691803e43
mozlint/license: remove .hg from the exclude list r#linter-reviewers, hsivonen r=linter-reviewers,ahal DONTBUILD

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f3b691803e43