167814 - Subscribe's progress meter extends past the tree's content outline.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2002-09-10-08, All OS, Modern and Classic.

Summary: Subscribe's progress meter overextends past the tree's content outline.

Steps to Reproduce:

1.  Launch Subscribe
2.  Click Refresh
3.  Look at the progress meter's overlapping with the subscribe tree's outline.

Expected Results:

It should cut off right where the edge of the outliner ends.

Actual Results:

It extends slightly past.  Note that this happens on Classic and Modern, so I'm
pretty sure it's not theme specific.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot exhibiting the problem

Comment 2

[Stefan Borggraefe]

Attachment: Fix

This patch gives the status bar the same margin as the tree above it. Tested
with Linux and Mac OS X (both Classic and Modern).

Thunderbird has this already fixed in the Pinstripe theme on Max OS X. I assume
once Qute is replaced by xyz-stripe this will be fixed on the other platforms,
too. In any case I don't think it makes sense to fix the Qute theme anymore.
Please correct me if I'm wrong.

Comment 3

[[e-mail]]

Comment on attachment 154100 [details] [diff] [review]
Fix

This sorta works on modern, because of the 4px statusbarpanel padding... I
suppose it's okay.

Comment 4

[Stefan Borggraefe]

Comment on attachment 154100 [details] [diff] [review]
Fix

Thanks for the review, Neil!

Seth, can you sr this patch?

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 154100 [details] [diff] [review]
Fix

sr=sspitzer

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of subscribe dialog from tbird (aviary 1.0 branch)

you might want to look at how mscott (?) fixed this issue in tbird.

Comment 7

[Stefan Borggraefe]

(In reply to comment #6)
> Created an attachment (id=154205)
> screen shot of subscribe dialog from tbird (aviary 1.0 branch)
> 
> you might want to look at how mscott (?) fixed this issue in tbird.

When you look at the screenshot closely, you see that this isn't fixed in the
Qute theme. The right border of the status bar is to far right. This is more
obvious with a Linux Gtk2 build, because there you get a different border
(probably the same is true when you turn off Windows XP's Luna theme, but I
can't test this at the moment).

But since this *is* fixed in the Pinstripe theme on the Mac, I assume this will
be fixed on the other platforms too when they are switched from Qute to *stripe.

You can see a screenshot of this area of the Subscribe dialog in a Mac OS X TB
build here: http://www.kuestner.org/images/stefan_b/TB-Pinstripe.pdf

I'll keep an eye on this and file/fix a TB-specific bug in case this isn't fixed
after the switch to *stripe on the other platforms.

I checked in the patch for Modern/Classic. Marking FIXED.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED (at least for my taste) on Windows XP Seamonkey, with Classic and
Modern themes, using build 2004-07-28-08