Closed Bug 1678188 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26571 - Made more robust 4 background-size tests

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

task

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26571 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26571
Details from upstream follow.

b'G\xc3\xa9rard Talbot <github@gtalbot.org>' wrote:

Made more robust 4 background-size tests

background-size-006.html
background-size-009.html
background-size-014.html
background-size-017.html

In all 4 tests: if the background-size property or background-size declaration is not supported or implemented by an UA, then the 4 tests will pass if we only read the pass-fail-conditions sentence: a green 60x60 square will be displayed... but it will fail when compare to reference file. Solution, improvement in the PR: change, replace 'background-image: url(support/60x60-green.png)' with 'background-image: url(support/1x1-green.png)' so that a filled 45x45 red square is displayed along with a tiny 1x1 green square. The modifications in this patch make things more clear for the tester if and when the 4 tests fail.

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

PASS: 4

Safari

PASS: 4

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b498311a589f [wpt PR 26571] - Made more robust 4 background-size tests, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.