1678207 - Remove or update probes expiring in Firefox 86: GPU_WAIT_TIME_MS

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, task)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 86 [1].

GPU_WAIT_TIME_MS

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #fx-metrics Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Viktor Z (he/they)]

Hi, I'd like to work on this!

Comment 2

[Viktor Z (he/they)]

Attachment: Bug 1678207 - Removed probe GPU_WAIT_TIME_MS from use file and definition file

Comment 3

[Viktor Z (he/they)]

To remove the expiring probe GPU_WAIT_TIME_MS:

Remove its use from line 49 from gfx/layers/d3d11/HelpersD3D11.h

Remove lines 14590 - 14601 from definition file toolkit/components/telemetry/Histograms.json

---

Test Results from toolkit/components/telemetry/tests/:

• Passed Browser Chrome Test suite
• Encountered unexpected test error: TEST-UNEXPECTED-FAIL | No tests collected (Not in PYTHON_UNITTEST_MANIFESTS?)
• mach error, could not find some test files from toolkit/components/telemetry/tests/marionette/tests/

Comment 4

[Viktor Z (he/they)]

Attachment: Patch for removing expiring probe GPU_WAIT_TIME_MS

Comment 5

[Mark Banner (:standard8)]

Brad, should this have been landed, since it has review+ ?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

I think I'd rather keep this code in. Although, we're not actively measuring it now, it's sometimes handy to have this stuff left around as documentation for when/if we want to measure it in the future.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:bhood, could you have a look please?
For more information, please visit auto_nag documentation.