1678237 - 0.76% installer size (osx-cross) regression on push 77ab0ef5c2035d065138c88ef087d6fe52c6e7fe (Tue November 17 2020)

Status: RESOLVED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a build_metrics performance regression from push 77ab0ef5c2035d065138c88ef087d6fe52c6e7fe. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
1%	installer size		osx-cross		79,249,562.17 -> 79,852,723.58

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1675568

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1678237 - compressing variants for LOS images

Comment 3

[Gavin Suntop [:gvn] (they/them)]

Hi Alexandru,

I have a patch up to reduce the regressing patches images by 550KB. Will that be an acceptable solution?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be60d6815956
compressing variants for LOS images r=thecount

Comment 5

[Gavin Suntop [:gvn] (they/them)]

[Tracking Requested - why for this release]:

Comment 6

[Gavin Suntop [:gvn] (they/them)]

Comment on attachment 9188926 [details]
Bug 1678237 - compressing variants for LOS images

Beta/Release Uplift Approval Request

• User impact if declined: Images for logged out save variants will not be weight-optimized. Without this there is a regression in the installer size.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1675568
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only compresses images, no code is changed.
• String changes made/needed: N/A

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/be60d6815956

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9188926 [details]
Bug 1678237 - compressing variants for LOS images

Looking at the graph, it appears this patch was effective. Approved for 84.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2beaa181998e