1678256 - 1.49 - 1.51% Base Content JS (macosx1014-64-shippable-qr) regression on push befecdb77ef7e391ebfe8bcf46d9ce32d1172945 (Tue November 10 2020)

Status: RESOLVED INVALID

(Core :: DOM: Content Processes, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a awsy performance regression from push befecdb77ef7e391ebfe8bcf46d9ce32d1172945. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
2%	Base Content JS		macosx1014-64-shippable-qr		2,798,629.33 -> 2,841,002.67
1%	Base Content JS		macosx1014-64-shippable-qr		2,796,952.00 -> 2,838,576.00

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
22%	Images		macosx1014-64-shippable-qr		6,808,488.80 -> 5,324,379.10
21%	Images		windows10-64-shippable		7,281,816.21 -> 5,743,408.09
20%	Images		linux1804-64-shippable		5,531,400.10 -> 4,416,162.52
20%	Images		linux1804-64-shippable-qr		5,723,944.14 -> 4,580,189.36
19%	Images		windows10-64-shippable-qr		7,683,332.16 -> 6,187,840.94
19%	Images		windows7-32-shippable		6,165,551.84 -> 5,005,238.78
14%	Explicit Memory		windows10-64-shippable		328,308,125.66 -> 282,289,160.78
14%	Explicit Memory		windows7-32-shippable		270,060,971.52 -> 232,226,621.77
14%	Resident Memory		linux1804-64-shippable-qr		1,147,429,973.58 -> 988,011,424.95
14%	Explicit Memory		linux1804-64-shippable		358,584,795.96 -> 309,388,253.07
14%	Explicit Memory		windows10-64-shippable-qr		347,818,343.53 -> 300,111,776.46
13%	Explicit Memory		linux1804-64-shippable-qr		599,887,245.23 -> 520,569,325.12
12%	Explicit Memory		macosx1014-64-shippable-qr		398,158,096.69 -> 348,672,169.15
12%	Resident Memory		windows10-64-shippable-qr		547,322,517.50 -> 479,487,633.70
11%	Resident Memory		windows10-64-shippable		507,236,742.83 -> 449,415,892.09
11%	Heap Unclassified		windows7-32-shippable		35,549,067.62 -> 31,636,763.74
11%	Heap Unclassified		windows10-64-shippable-qr		56,739,704.72 -> 50,561,922.16
10%	Heap Unclassified		linux1804-64-shippable-qr		288,328,260.46 -> 258,227,806.70
10%	Heap Unclassified		windows10-64-shippable		44,664,979.54 -> 40,177,199.78
10%	JS		linux1804-64-shippable-qr		88,494,494.90 -> 79,660,064.82
10%	JS		linux1804-64-shippable		88,521,389.48 -> 79,873,908.01
10%	Resident Memory		linux1804-64-shippable		627,056,782.27 -> 565,954,584.79
9%	Resident Memory		macosx1014-64-shippable-qr		787,653,100.93 -> 714,441,972.31
9%	JS		windows10-64-shippable-qr		89,035,157.31 -> 80,776,586.75
9%	JS		windows10-64-shippable		88,619,251.19 -> 80,547,273.17
9%	Resident Memory		windows7-32-shippable		528,511,962.94 -> 480,395,089.35
9%	JS		macosx1014-64-shippable-qr		89,875,671.52 -> 82,001,873.13
8%	Heap Unclassified		linux1804-64-shippable		69,651,112.99 -> 64,218,327.82
7%	JS		windows7-32-shippable		66,986,737.48 -> 62,417,510.05
7%	Images		linux1804-64-shippable-qr	tp6	8,421,448.20 -> 7,860,156.90
6%	Heap Unclassified		macosx1014-64-shippable-qr		109,628,575.20 -> 103,274,877.49
6%	Images		windows7-32-shippable	tp6	7,873,318.17 -> 7,429,401.20
5%	Images		macosx1014-64-shippable-qr	tp6	9,296,358.33 -> 8,810,724.50

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Those listed improvements are looking exactly the same as previously reported via 1669169 comment 15. I'm confused now, given that this was caused by different bugs now? In Marionette we indeed fixed a major memory leak, and I doubt that the patch on bug 1669961 could have caused such improvements. But I will leave that to Kris.

Comment 2

[Kris Maglione [:kmag]]

I'm not sure exactly what's happening here, but I don't think it was caused by that push.