1678298 - URL in popup (over an entry in "Network" tab of Developer tools) is not decoded fully

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Eugen Konkov]

Attachment: _4.jpg

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

See url in devtools,

Actual results:

I hover over url and when hint is displayed the url is not fully decoded, despite on at list it is fully decoded

Expected results:

Url should be fully decoded and displayed

PS. Why firefox version is not filled automatically for the ticket??

Comment 1

[Simona Badau]

Assigning this to the Netmonitor component so that someone more experienced in this area can take a look over, please move this issue to the right component if this is not the correct one.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting.

I can reproduce it. It looks like parts of the url are not decoded properly.

Comment 3

[Hubert Boma Manilla (:bomsy)]

Another STR

1. Go to https://www.feelsafe.at/
2. Open the devtools and switch to the network panel
3. Refresh to load all the requests
4. Type "service-reviews" in the search to filter the request list
5. Hover over the File column to see the Url tool tip

AR
The URL in the decoded section does not seem to be fully decoded.

ER
The URL in the decoded section should be fully decoded.

Comment 4

[Hubert Boma Manilla (:bomsy)]

For anyone interested in working on this.

This is where tool tip gets created
https://searchfox.org/mozilla-central/rev/0db73daa4b03ce7513a7dd5f31109143dc3b149e/devtools/client/netmonitor/src/components/request-list/RequestListColumnFile.js#48,58-61
It looks like we use the unicodeUrl from urlDetails for the decoded part.

The unicodeUrl is created here, it calls getUnicodeUrl
https://searchfox.org/mozilla-central/rev/0db73daa4b03ce7513a7dd5f31109143dc3b149e/devtools/client/netmonitor/src/utils/request-utils.js#284

getUnicodeUrl uses decodeURI to decode the url here
https://searchfox.org/mozilla-central/rev/0db73daa4b03ce7513a7dd5f31109143dc3b149e/devtools/client/shared/unicode-url.js#91

It seems decodeURI might not be decoding completely, maybe we can use decodeURIComponent instead or something else.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/decodeURI
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/decodeURIComponent

Comment 5

[Rahul]

I've downloaded the code and fixed this issue, could you please tell me how to submit a PR?

Comment 6

[Rahul]

Attachment: Bug 1678298 - Fixed Bugzilla issue #1678298 r=bomsy

Comment 7

[Rahul]

Attachment: Bug 1678298 - [devtools] Use decodeURIComponent instead of decodeURI r=bomsy

Depends on D98294

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b4e5058f64d
[devtools] Use decodeURIComponent instead of decodeURI r=bomsy

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9b4e5058f64d