Closed Bug 1678306 Opened 7 months ago Closed 7 months ago

Expose HTTPS-Only preference in privacy.network

Categories

(WebExtensions :: General, enhancement, P1)

enhancement

Tracking

(firefox84 fixed, firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox84 --- fixed
firefox85 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

We would like to expose the preference (maybe read-only) so that extensions can observe if https-only is flipped on, in particular https-everywhere would like to know.

Maybe something similar to Bug 1593635 ?

Shane, could you provide some pointers on what the preferred way of exposing a preference is these days?

Flags: needinfo?(mixedpuppy)
Summary: Exposse HTTPS-Only preference in browser-settings → Expose HTTPS-Only preference in browser-settings
Keywords: dev-doc-needed
Summary: Expose HTTPS-Only preference in browser-settings → Expose HTTPS-Only preference in privacy.network
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb0709aaa89d
Expose HTTPS-Only preference to extensions within privacy.network. r=robwu,mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

Comment on attachment 9189141 [details]
Bug 1678306: Expose HTTPS-Only preference to extensions within privacy.network.

Beta/Release Uplift Approval Request

  • User impact if declined: Users of the famous and largely used extension HTTPS-Everywhere will be in some kind of limbo state if Firefox Users enable HTTPS-Only Mode. Within this patch we expose a signal to extensions that allows to check if HTTPS-Only is enabled. Folks from the EFF (maintaners of https-everywhere) request if it's possible to uplift that so it's in FF 84.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): We are just exposing a read-only pref indicating if HTTPS-Only Mode is enabled.
  • String changes made/needed: no
Attachment #9189141 - Flags: approval-mozilla-beta?

Comment on attachment 9189141 [details]
Bug 1678306: Expose HTTPS-Only preference to extensions within privacy.network.

Makes the value of a couple prefs visible to extensions. No real user impact otherwise. Approved for 84.0rc1.

Attachment #9189141 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.