1678306 - Expose HTTPS-Only preference in privacy.network

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Christoph Kerschbaumer [:ckerschb]]

We would like to expose the preference (maybe read-only) so that extensions can observe if https-only is flipped on, in particular https-everywhere would like to know.

Maybe something similar to Bug 1593635 ?

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Shane, could you provide some pointers on what the preferred way of exposing a preference is these days?

Comment 2

[Shane Caraveo (:mixedpuppy)]

I probably put this into privacy.network. browserSettings is generally more browser-feature related.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/network

I'm assuming it would be pretty simple, something like this (and you can pass readOnly: true in the call to getSettingsAPI):

https://searchfox.org/mozilla-central/rev/1d34bd022de0b55c81d9db6026f69bda1d4a86d2/toolkit/components/extensions/parent/ext-privacy.js#75-82
https://searchfox.org/mozilla-central/rev/1d34bd022de0b55c81d9db6026f69bda1d4a86d2/toolkit/components/extensions/parent/ext-privacy.js#316-322

And you'd have to add to the schema.

https://searchfox.org/mozilla-central/rev/1d34bd022de0b55c81d9db6026f69bda1d4a86d2/toolkit/components/extensions/schemas/privacy.json#72-75

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1678306: Expose HTTPS-Only preference to extensions within privacy.network.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb0709aaa89d
Expose HTTPS-Only preference to extensions within privacy.network. r=robwu,mixedpuppy

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eb0709aaa89d

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 9189141 [details]
Bug 1678306: Expose HTTPS-Only preference to extensions within privacy.network.

Beta/Release Uplift Approval Request

• User impact if declined: Users of the famous and largely used extension HTTPS-Everywhere will be in some kind of limbo state if Firefox Users enable HTTPS-Only Mode. Within this patch we expose a signal to extensions that allows to check if HTTPS-Only is enabled. Folks from the EFF (maintaners of https-everywhere) request if it's possible to uplift that so it's in FF 84.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are just exposing a read-only pref indicating if HTTPS-Only Mode is enabled.
• String changes made/needed: no

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9189141 [details]
Bug 1678306: Expose HTTPS-Only preference to extensions within privacy.network.

Makes the value of a couple prefs visible to extensions. No real user impact otherwise. Approved for 84.0rc1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/10de20a9b667

Comment 9

[Richard Bloor]

Documentation updated in #1645 Adds httpsOnlyMode description to privacy.network page and confirmed that privacy isn't the subject of one of the web extension examples.