1678336 - The “Remove All” strings are displayed on the button from the "Remove this login?"/”Remove this login from all devices?” dialog

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

[Affected versions]:

• Firefox Nightly 85.0a1 (Build ID: 20201119095716)

[Affected Platforms]:

• Mac 10.15.6
• Windows 10 x64
• Ubuntu 20.04 x64.

[Prerequisites]:

• Have the latest version of Firefox Nightly installed.
• Have a Firefox profile with only one saved login.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the "about:logins" page.
3. Click on the Menu button.
4. Select the “Remove All Logins…” option.
5. Observe the “Remove” button from the "Remove this login?"/”Remove this login from all devices?” dialog.

[Expected result]:

• The button contains the “Remove” string.

[Actual result]:

• The button contains “Remove All” strings.

[Notes]:

• Attached a screenshot with the issue.

Comment 1

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: Lockwise_RemoveButton.PNG

Comment 2

[Tim Giles [:tgiles]]

I believe this is expected behavior, pulling in Katie to confirm this behavior. It might be divergent from the UX spec listed on the remove all logins ticket, but some changes were made that are not reflected in that UX spec.

Comment 3

[katieC]

This bug is correct. In the case where:
• only 1 login to remove, the red button should display, "Remove"
• 2 or more logins will be removed, the red button should display, "Remove All"

Tim, when we get to multi-select removal, the situation is similar. Single login removal vs multiple logins removal - button language confirms action to the user.

Comment 4

[Tim Giles [:tgiles]]

Attachment: Bug 1678336 - Fix 'Remove All' string in remove all logins dialog to use singular case. r=sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeee2b548e51
Fix 'Remove All' string in remove all logins dialog to use singular case. r=sfoster,fluent-reviewers,flod

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/eeee2b548e51

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue and is no longer reproducible using the latest Firefox Nightly 85.0a1 (Build ID: 20201207215505) on Windows 10 x64, Ubuntu 20.04 and Mac 10.15.7.