Closed Bug 1678352 Opened 4 years ago Closed 3 years ago

Intermittent TestAudioTrackGraph.AudioInputTrackDisabling | Expected equality of these values:

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P5)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- fixed
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: padenot)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disable-recommended])

Attachments

(9 files)

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=322304848&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RKXrBYJMRkqwoPeXbJCujw/runs/0/artifacts/public/logs/live_backing.log


INFO -  TEST-START | TestAudioTrackGraph.AudioInputTrackDisabling
[task 2020-11-19T14:48:56.357Z] 14:48:56     INFO -  nrDiscontinuities4
[task 2020-11-19T14:48:56.357Z] 14:48:56  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.AudioInputTrackDisabling | Expected equality of these values:
[task 2020-11-19T14:48:56.357Z] 14:48:56     INFO -    nrDiscontinuities
[task 2020-11-19T14:48:56.357Z] 14:48:56     INFO -      Which is: 4
[task 2020-11-19T14:48:56.357Z] 14:48:56     INFO -    ITERATION_COUNT
[task 2020-11-19T14:48:56.357Z] 14:48:56     INFO -      Which is: 5 @ /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:666
[task 2020-11-19T14:48:56.357Z] 14:48:56  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.AudioInputTrackDisabling | test completed (time: 1098ms)
[task 2020-11-19T14:48:56.357Z] 14:48:56     INFO -  TEST-START | TestAudioTrackGraph.CrossGraphPort```

This looks to be a regression from Bug 1674283 https://hg.mozilla.org/integration/autoland/rev/3897000a524802aad5d424b73d70d45718b93ef9
Paul, could you please have a look over it? It spiked in the last week on windows10-64 both opt and debug: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2021-01-09&endday=2021-01-16&tree=trunk&bug=1678352
Thank you.

Flags: needinfo?(padenot)
Regressed by: 1674283
Has Regression Range: --- → yes
Assignee: nobody → padenot
Status: NEW → ASSIGNED

Both are useful, so I kept the previous function as well.

Depends on D102215

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb213d0b4dc9
Add some namespaces to WavDumper.h so it can be used outside the mozilla namespace. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/2b9357f8ecf1
Add a way to explicitly specify the name of the file to dump audio in WavDumper. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/9d6b574723e1
Teach MockCubeb to record its own input to a buffer. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/ac3b4680332e
Upload a wav file when the test fails, for diagnosis. r=pehrsons

Paul,can you take a look? this started failing again
Failure log: https://treeherder.mozilla.org/logviewer?job_id=327219674&repo=autoland&lineNumber=29937

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 86 Branch → ---

Yes, it's an investigation patch, I should have put leave-open.

Flags: needinfo?(padenot)
Attached image cause

This is a picture of the recorded output on a failing test, zoomed in quite far in audacity. We see that by chance we're muting more or less exactly at a new period, so the algorithm doesn't detect a discontinuity, because it considers a discontinuity to be a difference in the signal that is more than:

Math.sin(2 * Math.PI * 100 / 44100) * 0.1 * 3
> 0.00427413111213094

and it's not the case in the picture above.

I'm going to switch to another method to detect that disabling the track mutes the track.

No memory usage, simpler code.

Whiteboard: [stockwell needswork:owner]

This bug failed 62 times in the last 7 days. Occurs on macosx1014-64-qr, windows10-64, windows7-32 on debug and opt build types.

Recent log:
https://treeherder.mozilla.org/logviewer?job_id=329068616&repo=autoland&lineNumber=30195

Paul: Can you please take a look at this bug?

Flags: needinfo?(padenot)
Whiteboard: [stockwell needswork:owner]
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/083680117c68
Rewrite SineWaveGenerator.h. r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/fcb87b92328b
Cleanup and fix test users of SineWaveGenerator.h r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/6520a07b8bff
Switch to computing the RMS to check for silence in AudioInputTrackDisabling. r=pehrsons
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

There have been 30 total failures in the last 7 days (recent failure log).
Affected platforms are:

  • macosx1015-64-shippable-qr
  • macosx1015-64-qr opt & debug

Update:
There have been 58 failures within the last 7 days:
• 14 failures on OS X 10.15 WebRender debug
• 40 failures on OS X 10.15 WebRender opt
• 4 failures on OS X 10.15 WebRender Shippable opt
Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=347593974&repo=autoland&lineNumber=29706

[task 2021-08-06T00:33:20.349Z] 00:33:20     INFO -  TEST-START | TestAudioTrackGraph.AudioInputTrackDisabling
[task 2021-08-06T00:33:21.177Z] 00:33:21  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.AudioInputTrackDisabling | Expected equality of these values:
[task 2021-08-06T00:33:21.178Z] 00:33:21     INFO -    rmsf32(&(data[startIdx]), 2, rate / 10)
[task 2021-08-06T00:33:21.178Z] 00:33:21     INFO -      Which is: 0.141421
[task 2021-08-06T00:33:21.178Z] 00:33:21     INFO -    0.0
[task 2021-08-06T00:33:21.178Z] 00:33:21     INFO -      Which is: 0 @ /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:632
[task 2021-08-06T00:33:21.178Z] 00:33:21  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.AudioInputTrackDisabling | test completed (time: 829ms)
[task 2021-08-06T00:33:21.179Z] 00:33:21     INFO -  TEST-START | TestAudioTrackGraph.CrossGraphPort
[task 2021-08-06T00:33:21.179Z] 00:33:21     INFO -  TestCrossGraphPort input: 44100, output: 44100, driftFactor: 1
[task 2021-08-06T00:33:21.776Z] 00:33:21     INFO -  TestCrossGraphPort input: 44100, output: 44100, driftFactor: 1.08
[task 2021-08-06T00:33:22.379Z] 00:33:22     INFO -  TestCrossGraphPort input: 44100, output: 44100, driftFactor: 0.92
[task 2021-08-06T00:33:23.043Z] 00:33:23     INFO -  TestCrossGraphPort input: 48000, output: 44100, driftFactor: 1
[task 2021-08-06T00:33:23.524Z] 00:33:23     INFO -  TestCrossGraphPort input: 48000, output: 44100, driftFactor: 1.08
[task 2021-08-06T00:33:24.151Z] 00:33:24     INFO -  TestCrossGraphPort input: 48000, output: 44100, driftFactor: 0.92
[task 2021-08-06T00:33:24.669Z] 00:33:24     INFO -  TestCrossGraphPort input: 44100, output: 48000, driftFactor: 1
[task 2021-08-06T00:33:25.393Z] 00:33:25     INFO -  TestCrossGraphPort input: 44100, output: 48000, driftFactor: 1.08
[task 2021-08-06T00:33:25.825Z] 00:33:25     INFO -  TestCrossGraphPort input: 44100, output: 48000, driftFactor: 0.92
[task 2021-08-06T00:33:26.527Z] 00:33:26     INFO -  TestCrossGraphPort input: 52110, output: 17781, driftFactor: 1
[task 2021-08-06T00:33:27.026Z] 00:33:27     INFO -  TestCrossGraphPort input: 52110, output: 17781, driftFactor: 1.08
[task 2021-08-06T00:33:27.537Z] 00:33:27     INFO -  TestCrossGraphPort input: 52110, output: 17781, driftFactor: 0.92
[task 2021-08-06T00:33:28.129Z] 00:33:28     INFO -  TEST-PASS | TestAudioTrackGraph.CrossGraphPort | test completed (time: 6952ms)
[task 2021-08-06T00:33:28.130Z] 00:33:28     INFO -  TEST-START | TestAudioTrackGraph.CrossGraphPortLargeBuffer
Whiteboard: [stockwell unknown] → [stockwell needswork:owner]

There have been 47 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • macosx1015-64-qr
  • macosx1015-64-shippable-qr
[task 2021-08-13T21:39:12.349Z] 21:39:12     INFO -  TEST-START | TestAudioTrackGraph.AudioInputTrackDisabling
[task 2021-08-13T21:39:13.279Z] 21:39:13  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.AudioInputTrackDisabling | Expected equality of these values:
[task 2021-08-13T21:39:13.279Z] 21:39:13     INFO -    rmsf32(&(data[startIdx]), 2, rate / 10)
[task 2021-08-13T21:39:13.280Z] 21:39:13     INFO -      Which is: 0.141421
[task 2021-08-13T21:39:13.280Z] 21:39:13     INFO -    0.0
[task 2021-08-13T21:39:13.280Z] 21:39:13     INFO -      Which is: 0 @ /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:632
[task 2021-08-13T21:39:13.281Z] 21:39:13  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.AudioInputTrackDisabling | Expected equality of these values:
[task 2021-08-13T21:39:13.281Z] 21:39:13     INFO -    rmsf32(&(data[startIdx]), 2, rate / 10)
[task 2021-08-13T21:39:13.281Z] 21:39:13     INFO -      Which is: 0.141421
[task 2021-08-13T21:39:13.281Z] 21:39:13     INFO -    0.0
[task 2021-08-13T21:39:13.281Z] 21:39:13     INFO -      Which is: 0 @ /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:632
[task 2021-08-13T21:39:13.282Z] 21:39:13  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.AudioInputTrackDisabling | test completed (time: 931ms)

There have been 49 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • macosx1015-64-qr
  • macosx1015-64-shippable-qr
Flags: needinfo?(padenot)

Hi Paul, this has reached the disable recommended queue, can you please take a look?

Flags: needinfo?(padenot)
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]

Thanks for the heads up, pushed to try with our logging system here: https://treeherder.mozilla.org/jobs?repo=try&revision=8cb244725fece1cd9b46175efede47d3fdec840a

Flags: needinfo?(padenot)

In retrospect this is too dependent on scheduling. We can and should do
something better. This will be easier to implement once I implement real offline
support for suspend/resume for offline MediaTrackGraph for OfflineAudioContext I
think.

Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: 87 Branch → 93 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: