1678361 - Crash in [@ mozilla::EditorEventListener::RefuseToDropAndHideCaret]

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Sean Feng [:sefeng]]

Crash report: https://crash-stats.mozilla.org/report/index/1c21240c-ec6f-49f5-a480-454ea0201118

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 6 frames of crashing thread:

0 XUL mozilla::EditorEventListener::RefuseToDropAndHideCaret editor/libeditor/EditorEventListener.cpp:811
1 XUL mozilla::EditorEventListener::DragOverOrDrop editor/libeditor/EditorEventListener.cpp
2 XUL mozilla::EditorEventListener::DragEnter editor/libeditor/EditorEventListener.cpp:799
3 XUL mozilla::EditorEventListener::HandleEvent editor/libeditor/EditorEventListener.cpp:349
4 XUL XUL@0x2d1f44f 
5 XUL mozilla::EventListenerManager::HandleEventInternal dom/events/EventListenerManager.cpp:1088

This looks like a null pointer crash. Not very frequent though.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1678361 - Return gracely when GetDataTransfer fails r=masayuki

DragEvent::GetDataTransfer() is fallible when memory allocation fails as it lazily constructs DataTransfer. This tries failing gracely when that happens.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19bed19b33b1
Return gracely when GetDataTransfer fails r=masayuki

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/19bed19b33b1