Closed
Bug 1678372
Opened 4 years ago
Closed 4 years ago
Refactor toolkit/components/pictureinpicture/tests to use isVideoPaused helper function
Categories
(Toolkit :: Video/Audio Controls, enhancement)
Tracking
()
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: jack1391, Assigned: jack1391)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 1678372 - Refactor Picture-in-Picture tests to use isVideoPaused helper function. r?mconley,gijs
47 bytes,
text/x-phabricator-request
|
Details | Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.198 Safari/537.36
A number of tests in toolkit/components/pictureinpicture/tests create functions to check if a video is paused. Recently a helper function was added to toolkit/components/pictureinpicture/tests/head.js that has this same functionality - https://searchfox.org/mozilla-central/source/toolkit/components/pictureinpicture/tests/head.js#819-830 . It would be good to refactor any tests that use similar functions to just use the now provided helper function in head.js.
|
||
Comment 1•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Component: Untriaged → Video/Audio Controls
Product: Firefox → Toolkit
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Assignee: nobody → jack1391
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f77e57a7f9a
Refactor Picture-in-Picture tests to use isVideoPaused helper function. r=mconley
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
status-firefox85:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•