1678416 - Continue refactoring CC/GC scheduling

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Steve Fink [:sfink] [:s:]]

This is a continuation of bug 1662254, which now has some patches riding the trains.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Implement IdleTaskRunner::SetBudget() and add some comments.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Move more state to CCGCScheduler

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Merge ICCRunner and CCRunner into a single CCRunner r=smaug

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Remove a couple of calls to TimeStamp::Now()

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Minor comment fixes

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Use a state descriptor table to control when to check for CC aborts and ForgetSkippable runs

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Move bodies of large inline CCGCScheduler methods after the class declaration

Comment 8

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Rename CC_WAITING -> CC_FINISHED

Comment 9

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Fix documentation of javascript.gc_delay.full

Comment 10

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Emit input filename in files generated for static prefs to make it easier to track backwards to a pref via searchfox

Comment 11

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Move statics into local scopes where they are used.

Comment 12

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Add a new Canceled state to stop overusing Inactive and thereby allow asserting that the state machine has been initialized

Comment 13

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - Create CCGCScheduler static methods to allow providing values on-demand to the scheduler, as well as provide a way to mock up the host for testing (see next patch)

Comment 14

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1678416 - gtest for CCGCScheduler

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85f35f5749a0
Implement IdleTaskRunner::SetBudget() and add some comments. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e845a32a60bd
Move more state to CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/882f7ebe33fe
Merge ICCRunner and CCRunner into a single CCRunner r=smaug
https://hg.mozilla.org/integration/autoland/rev/61d9f960b80e
Remove a couple of calls to TimeStamp::Now() r=smaug
https://hg.mozilla.org/integration/autoland/rev/cc5f7ecb3922
Minor comment fixes r=smaug

Comment 16

[Razvan Maries]

Backed out for build bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=KFnmTWdIQF6AbpzieeQDbw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=cc5f7ecb39229709139ac45e3894c3285f917f2b

Log: https://treeherder.mozilla.org/logviewer?job_id=323531504&repo=autoland&lineNumber=10612

Backout: https://hg.mozilla.org/integration/autoland/rev/02f3d63edaf43f96551f04159c66bd71fb831af5

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da6bf0cf9452
Implement IdleTaskRunner::SetBudget() and add some comments. r=smaug
https://hg.mozilla.org/integration/autoland/rev/43a3d7b7427f
Move more state to CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/98e3c0081e71
Merge ICCRunner and CCRunner into a single CCRunner r=smaug
https://hg.mozilla.org/integration/autoland/rev/73ff3778d4ef
Remove a couple of calls to TimeStamp::Now() r=smaug
https://hg.mozilla.org/integration/autoland/rev/2d1b42a3ef14
Minor comment fixes r=smaug

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/da6bf0cf9452
https://hg.mozilla.org/mozilla-central/rev/43a3d7b7427f
https://hg.mozilla.org/mozilla-central/rev/98e3c0081e71
https://hg.mozilla.org/mozilla-central/rev/73ff3778d4ef
https://hg.mozilla.org/mozilla-central/rev/2d1b42a3ef14

Comment 19

[Phabricator Automation]

Comment on attachment 9191181 [details]
Bug 1678416 - Use a state descriptor table to control when to check for CC aborts and ForgetSkippable runs

Revision D90902 was moved to bug 1662254. Setting attachment 9191181 [details] to obsolete.

Comment 20

[Phabricator Automation]

Comment on attachment 9191182 [details]
Bug 1678416 - Move bodies of large inline CCGCScheduler methods after the class declaration

Revision D94791 was moved to bug 1662254. Setting attachment 9191182 [details] to obsolete.

Comment 21

[Phabricator Automation]

Comment on attachment 9191183 [details]
Bug 1678416 - Rename CC_WAITING -> CC_FINISHED

Revision D94792 was moved to bug 1662254. Setting attachment 9191183 [details] to obsolete.

Comment 22

[Phabricator Automation]

Comment on attachment 9191184 [details]
Bug 1678416 - Fix documentation of javascript.gc_delay.full

Revision D94793 was moved to bug 1662254. Setting attachment 9191184 [details] to obsolete.

Comment 23

[Phabricator Automation]

Comment on attachment 9191187 [details]
Bug 1678416 - Add a new Canceled state to stop overusing Inactive and thereby allow asserting that the state machine has been initialized

Revision D95951 was moved to bug 1662254. Setting attachment 9191187 [details] to obsolete.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98ec5fb8bdd9
Emit input filename in files generated for static prefs to make it easier to track backwards to a pref via searchfox r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/a0e92921874a
Move statics into local scopes where they are used. r=smaug

Comment 25

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/98ec5fb8bdd9
https://hg.mozilla.org/mozilla-central/rev/a0e92921874a

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a606677aefc4
Create CCGCScheduler static methods to allow providing values on-demand to the scheduler, as well as provide a way to mock up the host for testing (see next patch) r=smaug
https://hg.mozilla.org/integration/autoland/rev/76b3d763c9af
gtest for CCGCScheduler r=smaug

Comment 27

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a606677aefc4
https://hg.mozilla.org/mozilla-central/rev/76b3d763c9af