1678470 - convert the serialization version of TransportSecurityInfo to an integer

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P2)

Description

[Dana Keeler (she/her) [:keeler]]

TransportSecurityInfo::Read has a number of lines like this:

  if (!serVersion.EqualsASCII("1") && !serVersion.EqualsASCII("2") &&
      !serVersion.EqualsASCII("3") && !serVersion.EqualsASCII("4") &&
      !serVersion.EqualsASCII("5")) {

This is cumbersome and potentially error-prone. Perhaps we should parse an integer out of serVersion and use that instead.

Comment 1

[Moritz Birghan [:mbirghan]]

Attachment: Bug 1678470 - convert the serialization version of TransportSecurityInfo to an integer. r=keeler

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/541d65cf0346
convert the serialization version of TransportSecurityInfo to an integer. r=keeler

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/541d65cf0346