1678542 - Random ARM64 fixes

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Lars T Hansen [:lth]]

Various fixes for bugs and poor code I've come across while investigating bug 1678097.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - Optimize branchTestPtr on ARM64. r?nbp

branchTestPtr can be optimized in the manner of branchTest32, using CBZ/CBNZ
when the inputs are the same and we're testing for zero/nonzero.

Also tidy up the logic of branchTest32 to make it slightly easier to understand.

Comment 2

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - Placeholder for patchable label on ARM64 must be ImmWord, not ImmPtr. r?nbp

This is not a functional change but allows switches to be emitted for wasm:
wasm disallows the use of an ImmPtr for movePatchablePtr but allows ImmWord,
this is in order to guard against embedded pointers in the serializable
machine code. For a patchable word that will always be patched after
code is deserialized, we can use ImmWord, as we do on other platforms.

Depends on D97770

Comment 3

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - Always sync the SP (WIP)

Every operation that updates the SP must be sure to sync the SP. Various
addToStackPtr APIs did not do this.

Depends on D97771

Comment 4

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - Don't clobber ptr register for ARM64 load/store. r?nbp

ARM64 inherited the wasmLoad / wasmStore API from ARM and MIPS wherein
the ptr register is clobberable by the macroassembler, so as to avoid
allocating a temp register. On ARM64 there are several temp registers,
so this is not necessary, and we can generate better code (from Ion)
by not clobbering.

Depends on D97771

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d84189f9e733
Optimize branchTestPtr on ARM64.  r=nbp
https://hg.mozilla.org/integration/autoland/rev/f49a0516ef05
Placeholder for patchable label on ARM64 must be ImmWord, not ImmPtr. r=nbp
https://hg.mozilla.org/integration/autoland/rev/10cf061462ef
Don't clobber ptr register for ARM64 load/store.  r=nbp

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d84189f9e733
https://hg.mozilla.org/mozilla-central/rev/f49a0516ef05
https://hg.mozilla.org/mozilla-central/rev/10cf061462ef

Comment 7

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - Add missing ARM64 porting APIs. r?nbp

Depends on D100025

Comment 8

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - ARM64 UDivConstantI must Lsr, not Asr. r?nbp

Depends on D100112

Comment 9

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - Fix ARM64 NegD and NegF output register. r?nbp

Depends on D100113

Comment 10

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - Add env var to trace execution of ARM64 SIM. r?nbp

Depends on D100114

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afb6bb63b47b
Fix ARM64 NegD and NegF output register. r=nbp
https://hg.mozilla.org/integration/autoland/rev/812fbada4509
Add env var to trace execution of ARM64 SIM. r=nbp
https://hg.mozilla.org/integration/autoland/rev/8a7adcf1b8cf
Add missing ARM64 porting APIs. r=nbp
https://hg.mozilla.org/integration/autoland/rev/e21ef34b502a
ARM64 UDivConstantI must Lsr, not Asr. r=nbp

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/afb6bb63b47b
https://hg.mozilla.org/mozilla-central/rev/812fbada4509
https://hg.mozilla.org/mozilla-central/rev/8a7adcf1b8cf
https://hg.mozilla.org/mozilla-central/rev/e21ef34b502a

Comment 13

[Phabricator Automation]

Comment on attachment 9189168 [details]
Bug 1678542 - Always sync the SP (WIP)

Revision D97772 was moved to bug 1678097. Setting attachment 9189168 [details] to obsolete.

Comment 14

[Lars T Hansen [:lth]]

Attachment: Bug 1678542 - test case for NegD bug. r?nbp

This was supposed to have landed with the bugfix. The bug
was that NegD and NegF chose their output register to be
their input register always, ignoring the output register
selected by the register allocator.

Depends on D100655

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2443007f889a
test case for NegD bug. r=nbp

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2443007f889a