1678572 - A github-release shouldn't kick off releases if the bot made it

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Johan Lorenzo [:jlorenzo]]

In bug 1648785, we enabled the Fenix release graph to upload signed APKs onto its corresponding github-release. In bug 1568466, we intend to deprecate github-releases as a way of kicking off releases in favor of shipit. Signed APKs will still be uploaded onto github-releases, though. This means, the release graph will create[1] a github-release instead of updating an existing one.

I haven't tried it, but I highly suspect this will induce and unwanted side effect. Here's the scenario I fear:

1. Shipit kicks off a release graph
2. This release graph publishes a github-release
3. This publication triggers a github event which listened by taskcluter[2], which kicks off an unwanted second release graph.

This is going a waste of resource since the second graph has the same output as the first one. We could stop supporting github-releases by simply removing this line[2]. Although, shipit introduces a new release procedure for the mobile team and I'd prefer to leave everybody enough time to get used to the new process. This means we should support both for several weeks.

Yesterday, I was chatting with :camd and he brought up a smart idea. This filter[2] could be extended with this kind of condition:

If the github event is triggered by one of the bots[3], then do nothing. Otherwise, kick the release off just like before.

I like this idea and I'll implement it before Fenix 84b2 starts.

[1] https://github.com/mozilla-releng/scriptworker-scripts/blob/a196a7a660a09de392e891d1fe0ea1c24e2381a8/githubscript/src/githubscript/github.py#L31
[2] https://github.com/mozilla-mobile/fenix/blob/4e598d16fc8a16edb992d82fc54eb1b8d2837b93/.taskcluster.yml#L107
[3] https://github.com/mozilla-release-automation-bot or https://github.com/mozilla-release-automation-bot-staging

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: [fenix] A github-release shouldn't kick off releases if the bot made it

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: [fenix] v84 uplift

Comment 3

[Johan Lorenzo [:jlorenzo]]

Each piece has landed. Closing

Comment 4

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/bb1ed5e44635
[fenix] Bug 1678572 - A github-release shouldn't kick off releases if the bot made it (https://github.com/mozilla-mobile/fenix/pull/16673)