1678586 - The Selection radio button from the system dialog panel is disabled if the system dialog was opened before the print preview finished loading

Status: NEW

(Toolkit :: Printing, defect, P3)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Selection.gif

Affected versions

• Firefox 84.0b3 (BuildId:20201119195818)
• Firefox 85.0a1 (BuildId:20201119214432)

Affected platforms

• Windows 10 64bit
• macOS 10.13
• Ubuntu 20.04 64bit

Steps to reproduce

1. Launch Firefox.
2. Access a long website like this one
3. Select a random portion of text.
4. Hit CTRL + P in order to open the print preview.
5. Click the “Print using the system dialog” option before the print preview finishes loading.

Expected result

• The “Selection” radio button is enabled.

Actual result

• The “Selection” radio button is disabled.

Regression Range

• This seems to be a regression:
• Pushlog
• Possible Regressor: Bug 1670222

Notes

• [Suggested Severity] I think that S3 fits for this issue.

Comment 1

[Emma Malysz]

We currently wait for the preview to finish rendering to see if the user has a selection https://searchfox.org/mozilla-central/rev/66547980e8e8ca583473c74f207cae5bac1ed541/toolkit/components/printing/content/print.js#645-649, and since we no longer are waiting for that, it makes sense why this would be disabled.

However, I wonder if we can insert a check when we handle "open-system-dialog" events to make sure the user can select this option

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(Moving bugs to 86, part 1.)

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Moving things to 88, cause we're mostly on Proton these days…