1678659 - empty menu item in menu bar on macOS for "hide other Bookmarks button from Bookmarks toolbar" option

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Sören Hentzschel]

Attachment: screenshot

bug 1674539 implemented an option to hide "Other Bookmarks" button from Bookmarks toolbar. It causes an menu item with empty label in the menu bar of macOS. The menu item in the context menu of the bookmarks toolbar has a label.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 1678659 - Remove 'Show Other Bookmarks' context menu item from the primary toolbar. r=jaws,Gijs

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1678659 - Update Fluent strings for bookmarks toolbar submenu. r?jaws

Depends on D97840

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25fab557664e
Remove 'Show Other Bookmarks' context menu item from the primary toolbar. r=jaws
https://hg.mozilla.org/integration/autoland/rev/80e1ce5c7bdc
Update Fluent strings for bookmarks toolbar submenu. r=jaws,fluent-reviewers

Comment 4

[Micah [:mtigley] (she/her)]

Comment on attachment 9189320 [details]
Bug 1678659 - Remove 'Show Other Bookmarks' context menu item from the primary toolbar. r=jaws,Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Users on MacOS will see a blank menu item when navigating to the "View > Toolbars" menu.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On MacOS, go to the "View > Toolbars" menu of the main toolbar.

ER:
Only the "Bookmarks Toolbar" menu should be shown.

AR:
The "Bookmarks Toolbar" menu AND a blank menu item are shown.

• List of other uplifts needed:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small change that removes showing the "Show Other Bookmarks" menu item from the "main" toolbar, which was introduced in Bug 1674539.
• String changes made/needed:

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/25fab557664e
https://hg.mozilla.org/mozilla-central/rev/80e1ce5c7bdc

Comment 6

[Simona Badau, Desktop QA]

I tried to verify this on the latest Nightly 85.0a1 but I can't reproduce the initial issue - followed the steps from Comment 4 on a clean profile on Mac OS X 10.15.7 using a Nightly build from 21 of November - build ID 20201121213746 (on a 16-inch, 2019, MacBook Pro).

Micah is there any additional step that I need to do in order to see the blank menu item from "View > Toolbars" menu?

Comment 7

[Micah [:mtigley] (she/her)]

(In reply to Simona Badau from comment #6)

Micah is there any additional step that I need to do in order to see the blank menu item from "View > Toolbars" menu?

You also need to have some bookmarks stored in "Other Bookmarks" for the menu item to appear. I forgot to add this step in the original STR. Sorry about that!

Comment 8

[Simona Badau, Desktop QA]

(In reply to Micah Tigley [:mtigley] from comment #7)

(In reply to Simona Badau from comment #6)

Micah is there any additional step that I need to do in order to see the blank menu item from "View > Toolbars" menu?

You also need to have some bookmarks stored in "Other Bookmarks" for the menu item to appear. I forgot to add this step in the original STR. Sorry about that!

Thanks, Micah!

After saving several bookmarks in the "Other Bookmarks" folder, I was able to reproduce this issue on a Nightly build from 21 of November - build ID 20201121213746.
I can confirm that this issue is verified as fixed on Mac OS X 10.15 using the latest Nightly 85.0a1 (Build ID: 20201202091636).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Bug 1674539 wasn't uplifted to Beta nor is it currently nominated to be. We don't need this for 84 unless that changes I believe?

Comment 10

[Micah [:mtigley] (she/her)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Bug 1674539 wasn't uplifted to Beta nor is it currently nominated to be. We don't need this for 84 unless that changes I believe?

Right and we don't want to uplift Bug 1674539 too since it's introducing a new string. I'll cancel the uplift request here.

Comment 11

[Micah [:mtigley] (she/her)]

Comment on attachment 9189320 [details]
Bug 1678659 - Remove 'Show Other Bookmarks' context menu item from the primary toolbar. r=jaws,Gijs

Canceling beta uplift here since the regressing bug (Bug 1674539) introduces a new string and we're already less than a week away from building 84.

Comment 12

[Catalin Sasca, Desktop QA [:csasca]]

Removing the qe+ flag, as it was already verified (see Comment 8)