Closed
Bug 1678767
Opened 4 years ago
Closed 8 months ago
[css-writing-modes] Make table row group reflow code only use logical coordinates
Categories
(Core :: Layout: Tables, defect, P3)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
121 Branch
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: TYLin)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1678767 Part 2 - Convert nsTableRowGroupFrame::SplitRowGroup() to logical coordinates. r?#layout
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
Some table code is still using physical coordinates, e.g.:
https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/layout/tables/nsTableRowGroupFrame.cpp#1103,1105-1106,1111,1130,1136-1137,1140,1159,1175,1181,1186-1187,1201,1212-1213
This all needs to use logical coordinates instead.
|
Assignee | |
Updated•9 months ago
|
Blocks: writing-mode
|
|
Assignee | |
Comment 1•8 months ago
|
||
|
||
Updated•8 months ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 months ago
|
||
Depends on D191367
|
|
Assignee | |
Comment 3•8 months ago
|
||
In layout code, we almost always operate on frames via pointers. With this
patch, we can eliminate extra & and *.
Depends on D191368
|
|
Assignee | |
Comment 4•8 months ago
|
||
Depends on D191369
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/18c8f88cd40d Part 1 - Convert nsTableRowGroupFrame::Reflow() to logical coordinates. r=dshin https://hg.mozilla.org/integration/autoland/rev/ba7a296ad588 Part 2 - Convert nsTableRowGroupFrame::SplitRowGroup() to logical coordinates. r=dshin https://hg.mozilla.org/integration/autoland/rev/9f6d4a1c1ffb Part 3 - Convert nsPresContext and frame arguments from references to pointers. r=dshin https://hg.mozilla.org/integration/autoland/rev/b5a7bfce6736 Part 4 - Convert nsTableRowGroupFrame::SplitSpanningCells() to use logical coordinates. r=dshin
|
|
Assignee | |
Updated•8 months ago
|
Summary: [css-writing-modes] Make table reflow code only use logical coordinates → [css-writing-modes] Make table row group reflow code only use logical coordinates
|
||
Comment 6•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/18c8f88cd40d
https://hg.mozilla.org/mozilla-central/rev/ba7a296ad588
https://hg.mozilla.org/mozilla-central/rev/9f6d4a1c1ffb
https://hg.mozilla.org/mozilla-central/rev/b5a7bfce6736
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox121:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•