1678767 - [css-writing-modes] Make table row group reflow code only use logical coordinates

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[Mats Palmgren (inactive)]

Some table code is still using physical coordinates, e.g.:
https://searchfox.org/mozilla-central/rev/2efcda6dc74c63863fd8f04a6d9d7ac6b09c7eca/layout/tables/nsTableRowGroupFrame.cpp#1103,1105-1106,1111,1130,1136-1137,1140,1159,1175,1181,1186-1187,1201,1212-1213
This all needs to use logical coordinates instead.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1678767 Part 1 - Convert nsTableRowGroupFrame::Reflow() to logical coordinates. r?#layout

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1678767 Part 2 - Convert nsTableRowGroupFrame::SplitRowGroup() to logical coordinates. r?#layout

Depends on D191367

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1678767 Part 3 - Convert nsPresContext and frame arguments from references to pointers. r?#layout

In layout code, we almost always operate on frames via pointers. With this
patch, we can eliminate extra & and *.

Depends on D191368

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1678767 Part 4 - Convert nsTableRowGroupFrame::SplitSpanningCells() to use logical coordinates. r?#layout

Depends on D191369

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18c8f88cd40d
Part 1 - Convert nsTableRowGroupFrame::Reflow() to logical coordinates. r=dshin
https://hg.mozilla.org/integration/autoland/rev/ba7a296ad588
Part 2 - Convert nsTableRowGroupFrame::SplitRowGroup() to logical coordinates. r=dshin
https://hg.mozilla.org/integration/autoland/rev/9f6d4a1c1ffb
Part 3 - Convert nsPresContext and frame arguments from references to pointers. r=dshin
https://hg.mozilla.org/integration/autoland/rev/b5a7bfce6736
Part 4 - Convert nsTableRowGroupFrame::SplitSpanningCells() to use logical coordinates. r=dshin

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/18c8f88cd40d
https://hg.mozilla.org/mozilla-central/rev/ba7a296ad588
https://hg.mozilla.org/mozilla-central/rev/9f6d4a1c1ffb
https://hg.mozilla.org/mozilla-central/rev/b5a7bfce6736