Closed Bug 1678768 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 26599 - Added 4 background-size (with no intrinsic and no ratio) tests

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26599 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26599
Details from upstream follow.

b'G\xc3\xa9rard Talbot <github@gtalbot.org>' wrote:

Added 4 background-size (with no intrinsic and no ratio) tests

This PR spun from
https://github.com/web-platform-tests/wpt/pull/22201
and is a followup to
[css-backgrounds-3] background-size with " auto" and gradient image is not interoperably implemented

Here are the last review comments from #22201 :
{
Ways this test can pass on an incorrect implementation:

  • UA doesn't support background-size at all, or ignores the declaration.
  • UA handles sizing in the y axis correctly, but not the x axis.
  • UA resolves to a size taller than the background positioning area. (We can't tell if the image was sized correctly, or oversized and clipped to the background painting area.)
  • UA assumes a 1:1 ratio -- such an incorrect assumption will still pass 4/6 subtests.
    }

Now the 4 (041 to 044) tests in here

  • declare 'background-repeat: no-repeat'
  • use a 2-color image (SVG image and linear-gradient)
  • use 'background-position: center'
  • have 'background-origin' declaration to be different from 'background-clip'
  • have 'background-origin' and 'background-clip' do not use their initial respective value
  • will fail if the UA doesn't support background-size at all, or ignores the declaration
Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

PASS: 2
FAIL: 2

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb9e63c8a28b
[wpt PR 26599] - Added 4 background-size (with no intrinsic and no ratio) tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eb9e63c8a28b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.